tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gokulavasan <...@git.apache.org>
Subject [GitHub] incubator-tephra pull request #31: (TEPHRA-214) Tool to debug the state and ...
Date Tue, 07 Feb 2017 22:43:23 GMT
Github user gokulavasan commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/31#discussion_r99949496
  
    --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/DataJanitorState.java
---
    @@ -129,17 +168,19 @@ public long getPruneUpperBoundForRegion(byte[] regionId) throws
IOException {
             Result next;
             while ((next = scanner.next()) != null) {
               byte[] region = getRegionFromKey(next.getRow());
    -          if (regions.contains(region)) {
    -            byte[] timeBytes = next.getValue(FAMILY, PRUNE_UPPER_BOUND_COL);
    -            if (timeBytes != null) {
    -              long pruneUpperBoundRegion = Bytes.toLong(timeBytes);
    -              resultMap.put(region, pruneUpperBoundRegion);
    +          if (regions == null || regions.contains(region)) {
    +            Cell cell = next.getColumnLatestCell(FAMILY, PRUNE_UPPER_BOUND_COL);
    +            if (cell != null) {
    +              byte[] pruneUpperBoundBytes = CellUtil.cloneValue(cell);
    +              long timestamp = cell.getTimestamp();
    --- End diff --
    
    @poornachandra It might be useful information to have right? I can rename it to something
else if you think compaction timestamp is misleading.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message