tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From poornachandra <...@git.apache.org>
Subject [GitHub] incubator-tephra pull request #31: (TEPHRA-214) Tool to debug the state and ...
Date Tue, 07 Feb 2017 07:50:30 GMT
Github user poornachandra commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/31#discussion_r99759970
  
    --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/DataJanitorState.java
---
    @@ -102,11 +107,29 @@ public void savePruneUpperBoundForRegion(byte[] regionId, long pruneUpperBound)
        * @throws IOException when not able to read the data from HBase
        */
       public long getPruneUpperBoundForRegion(byte[] regionId) throws IOException {
    +    RegionPruneInfo regionPruneInfo = getPruneInfoForRegion(regionId);
    +    return (regionPruneInfo == null) ? -1 : regionPruneInfo.getCompactionTimestamp();
    +  }
    +
    +  /**
    +   * Get the latest {@link RegionPruneInfo} for a given region.
    +   *
    +   * @param regionId region id
    +   * @return {@link RegionPruneInfo} for the region
    +   * @throws IOException when not able to read the data from HBase
    +   */
    +  public RegionPruneInfo getPruneInfoForRegion(byte[] regionId) throws IOException {
    --- End diff --
    
    This method needs to be annotated as `@Nullable`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message