Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E3B29200C17 for ; Fri, 27 Jan 2017 03:23:30 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id E23EF160B50; Fri, 27 Jan 2017 02:23:30 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 367B6160B4C for ; Fri, 27 Jan 2017 03:23:30 +0100 (CET) Received: (qmail 22732 invoked by uid 500); 27 Jan 2017 02:23:29 -0000 Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tephra.incubator.apache.org Delivered-To: mailing list dev@tephra.incubator.apache.org Received: (qmail 22721 invoked by uid 99); 27 Jan 2017 02:23:29 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Jan 2017 02:23:29 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 0B25DC0096 for ; Fri, 27 Jan 2017 02:23:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.199 X-Spam-Level: X-Spam-Status: No, score=-1.199 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id HGrxqX1mnoGu for ; Fri, 27 Jan 2017 02:23:28 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 9563B5F472 for ; Fri, 27 Jan 2017 02:23:27 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B8998E02A9 for ; Fri, 27 Jan 2017 02:23:24 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 770D82528B for ; Fri, 27 Jan 2017 02:23:24 +0000 (UTC) Date: Fri, 27 Jan 2017 02:23:24 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@tephra.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (TEPHRA-212) CompactionState #savePruneUpperBoundForRegion put call might because problems if regions are not available MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 27 Jan 2017 02:23:31 -0000 [ https://issues.apache.org/jira/browse/TEPHRA-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15840851#comment-15840851 ] ASF GitHub Bot commented on TEPHRA-212: --------------------------------------- Github user poornachandra commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/29#discussion_r98135660 --- Diff: tephra-core/src/main/java/org/apache/tephra/TxConstants.java --- @@ -369,6 +369,12 @@ * Interval in seconds to schedule prune run. */ public static final String PRUNE_INTERVAL = "data.tx.prune.interval"; + + /** + * Interval in seconds to schedule flush of prune table entries to store. + */ + public static final String PRUNE_FLUSH_INTERVAL = "data.tx.prune.flush.interval"; --- End diff -- Looks like this is not used anywhere. Also I don't think we need this > CompactionState #savePruneUpperBoundForRegion put call might because problems if regions are not available > ---------------------------------------------------------------------------------------------------------- > > Key: TEPHRA-212 > URL: https://issues.apache.org/jira/browse/TEPHRA-212 > Project: Tephra > Issue Type: Bug > Affects Versions: 0.11.0-incubating > Reporter: Gokul Gunasekaran > Assignee: Gokul Gunasekaran > Fix For: 0.11.0-incubating > > > If the regions corresponding to prune state table are not available, trying to do a put to that table might cause multiple retries etc and might cause issues. Instead of doing this write in a synchronous fashion, this should be done asynchronously. -- This message was sent by Atlassian JIRA (v6.3.4#6332)