Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@tephra.incubator.apache.org
Date: Tue, 31 Jan 2017 22:28:51 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@tephra.incubator.apache.org
Message-ID: <JIRA.13036673.1484942958000.3429.1485901731964@Atlassian.JIRA>
In-Reply-To: <JIRA.13036673.1484942958000@Atlassian.JIRA>
References: <JIRA.13036673.1484942958000@Atlassian.JIRA> <JIRA.13036673.1484942958800@jira-lw-us.apache.org>
Subject: [jira] [Commented] (TEPHRA-212) CompactionState
 #savePruneUpperBoundForRegion put call might because problems if regions
 are not available
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 31 Jan 2017 22:29:04 -0000


    [ https://issues.apache.org/jira/browse/TEPHRA-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15847645#comment-15847645 ] 

ASF GitHub Bot commented on TEPHRA-212:
---------------------------------------

Github user poornachandra commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/29#discussion_r98782081
  
    --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java ---
    @@ -324,7 +326,10 @@ public InternalScanner preCompactScannerOpen(ObserverContext<RegionCoprocessorEn
                                           TxConstants.TransactionPruning.DEFAULT_PRUNE_ENABLE);
             String pruneTable = conf.get(TxConstants.TransactionPruning.PRUNE_STATE_TABLE,
                                          TxConstants.TransactionPruning.DEFAULT_PRUNE_STATE_TABLE);
    -        compactionState = new CompactionState(c.getEnvironment(), TableName.valueOf(pruneTable));
    +        long pruneFlushInterval = TimeUnit.SECONDS.toMillis(
    +          conf.getLong(TxConstants.TransactionPruning.PRUNE_FLUSH_INTERVAL,
    +                       TxConstants.TransactionPruning.DEFAULT_PRUNE_FLUSH_INTERVAL));
    +        compactionState = new CompactionState(c.getEnvironment(), TableName.valueOf(pruneTable), pruneFlushInterval);
    --- End diff --
    
    Compaction stat needs to be created only if `pruneEnable` is true, right?


> CompactionState #savePruneUpperBoundForRegion put call might because problems if regions are not available
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: TEPHRA-212
>                 URL: https://issues.apache.org/jira/browse/TEPHRA-212
>             Project: Tephra
>          Issue Type: Bug
>    Affects Versions: 0.11.0-incubating
>            Reporter: Gokul Gunasekaran
>            Assignee: Gokul Gunasekaran
>             Fix For: 0.11.0-incubating
>
>
> If the regions corresponding to prune state table are not available, trying to do a put to that table might cause multiple retries etc and might cause issues. Instead of doing this write in a synchronous fashion, this should be done asynchronously.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)