Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@tephra.incubator.apache.org
Date: Wed, 25 Jan 2017 03:14:26 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@tephra.incubator.apache.org
Message-ID: <JIRA.13035674.1484687181000.195447.1485314066827@Atlassian.JIRA>
In-Reply-To: <JIRA.13035674.1484687181000@Atlassian.JIRA>
References: <JIRA.13035674.1484687181000@Atlassian.JIRA> <JIRA.13035674.1484687181007@jira-lw-us.apache.org>
Subject: [jira] [Commented] (TEPHRA-210) Streamline where tephra properties
 are fetched in TransactionProcessor coprocessor
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 25 Jan 2017 03:14:33 -0000


    [ https://issues.apache.org/jira/browse/TEPHRA-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837104#comment-15837104 ] 

ASF GitHub Bot commented on TEPHRA-210:
---------------------------------------

Github user poornachandra commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/28#discussion_r97702427
  
    --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java ---
    @@ -303,10 +305,22 @@ public InternalScanner preCompactScannerOpen(ObserverContext<RegionCoprocessorEn
         // Get the latest tx snapshot state for the compaction
         TransactionVisibilityState snapshot = cache.getLatestState();
     
    -    // Record tx state before the compaction
    -    if (compactionState != null) {
    +    if (pruneEnable == null) {
    +      Configuration conf = getConfiguration(c.getEnvironment());
    +      pruneEnable = conf.getBoolean(TxConstants.TransactionPruning.PRUNE_ENABLE,
    --- End diff --
    
    Since this code does not change between Tehpra and derived class implementation, we may need to handle the case when configuration is not available after startup. What do you think? 


> Streamline where tephra properties are fetched in TransactionProcessor coprocessor
> ----------------------------------------------------------------------------------
>
>                 Key: TEPHRA-210
>                 URL: https://issues.apache.org/jira/browse/TEPHRA-210
>             Project: Tephra
>          Issue Type: Improvement
>            Reporter: Gokul Gunasekaran
>            Assignee: Gokul Gunasekaran
>             Fix For: 0.11.0-incubating
>
>
> Tephra properties that are being in the TransactionProcessor coprocessor are:
> TxConstants.ALLOW_EMPTY_VALUES_KEY
> TxConstants.READ_NON_TX_DATA
> TxConstants.Manager.CFG_TX_MAX_LIFETIME
> TxConstants.TransactionPruning.PRUNE_ENABLE
> TxConstants.TransactionPruning.PRUNE_STATE_TABLE
> Out of the above properties, first two are table specific and thus ideally should come from the tableDesc (and can default to the value in env.getConfiguration). The other three properties should fetched from a ``Configuration`` provided by a protected method that could be overriden by derived classes (default implementation could still fetch it from env.getConfiguration). Moreover, these two properties are used in filtering of data during Hbase client calls and thus need to be available right away (unlike the other three properties which are used only in background operations such as compaction).
> Use Case:  When Tephra is used in other projects, the user of TransactionProcessor coprocessor can provide a way to get this configuration instead of relying on hbase-site.xml always.
> Proposal: Read the table specific properties in coprocessor, such as ALLOW_EMPTY_VALUES, READ_NON_TX_DATA from tableDescriptor and fall back to env.getConfiguration. For other three properties, introduce a method whose default implementation returns env.getConfiguration() that contains those properties, which could be overriden by derived classes. Also, these three values should loaded lazily when required during compaction/flush.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)