Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@tephra.incubator.apache.org
Date: Tue, 10 Jan 2017 02:23:58 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@tephra.incubator.apache.org
Message-ID: <JIRA.13033208.1484000328000.692011.1484015038439@Atlassian.JIRA>
In-Reply-To: <JIRA.13033208.1484000328000@Atlassian.JIRA>
References: <JIRA.13033208.1484000328000@Atlassian.JIRA> <JIRA.13033208.1484000328928@arcas>
Subject: [jira] [Commented] (TEPHRA-208) Compaction removes rows incorrectly
 for family deletes with column level conflict detection
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Tue, 10 Jan 2017 02:24:03 -0000


    [ https://issues.apache.org/jira/browse/TEPHRA-208?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1581=
3586#comment-15813586 ]=20

ASF GitHub Bot commented on TEPHRA-208:
---------------------------------------

GitHub user twdsilva opened a pull request:

    https://github.com/apache/incubator-tephra/pull/26

    TEPHRA-208 Compaction removes rows incorrectly for family deletes wit=
=E2=80=A6

    =E2=80=A6h column level conflict detection
   =20
    @poornachandra  @gokulavasan =20


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twdsilva/incubator-tephra TEPHRA-208

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tephra/pull/26.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #26
   =20
----
commit e6fd62d6d86c8fb9cf89b6f727c53f14dd215465
Author: Thomas D'Silva <tdsilva@salesforce.com>
Date:   2017-01-09T23:02:00Z

    TEPHRA-208 Compaction removes rows incorrectly for family deletes with =
column level conflict detection

----


> Compaction removes rows incorrectly for family deletes with column level =
conflict detection=20
> -------------------------------------------------------------------------=
-------------------
>
>                 Key: TEPHRA-208
>                 URL: https://issues.apache.org/jira/browse/TEPHRA-208
>             Project: Tephra
>          Issue Type: Bug
>    Affects Versions: 0.9.0-incubating
>            Reporter: Thomas D'Silva
>            Assignee: Poorna Chandra
>         Attachments: TEPHRA-208.patch
>
>
> In DeleteTracker we only check the timestamp while removing cells during =
compaction. If the previous row had a family delete, cells from subsequent =
rows could also be compacted.=20
> The attached test fails without the following change
> {code}
> private static final class DeleteTracker {
>      private long familyDeleteTs;
> +    private byte[] rowKey;
> =20
>      public static boolean isFamilyDelete(Cell cell) {
>        return !TxUtils.isPreExistingVersion(cell.getTimestamp()) &&
> @@ -300,14 +301,17 @@ public class TransactionVisibilityFilter extends Fi=
lterBase {
> =20
>      public void addFamilyDelete(Cell delete) {
>        this.familyDeleteTs =3D delete.getTimestamp();
> +      this.rowKey =3D Bytes.copy(delete.getRowArray(), delete.getRowOffs=
et(), delete.getRowLength());
>      }
> =20
>      public boolean isDeleted(Cell cell) {
> -      return cell.getTimestamp() <=3D familyDeleteTs;
> +      return rowKey !=3D null && Bytes.compareTo(cell.getRowArray(), cel=
l.getRowOffset(),=20
> +        cell.getRowLength(), rowKey, 0, rowKey.length) =3D=3D 0 && cell.=
getTimestamp() <=3D familyDeleteTs;
>      }
> =20
>      public void reset() {
>        this.familyDeleteTs =3D 0;
> +      this.rowKey =3D null;
>      }
>    }
>  }
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)