Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@tephra.incubator.apache.org
Date: Wed, 18 Jan 2017 23:06:26 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@tephra.incubator.apache.org
Message-ID: <JIRA.13033208.1484000328000.46326.1484780786761@Atlassian.JIRA>
In-Reply-To: <JIRA.13033208.1484000328000@Atlassian.JIRA>
References: <JIRA.13033208.1484000328000@Atlassian.JIRA> <JIRA.13033208.1484000328928@jira-lw-us.apache.org>
Subject: [jira] [Commented] (TEPHRA-208) Compaction removes rows incorrectly
 for family deletes with column level conflict detection
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 18 Jan 2017 23:06:32 -0000


    [ https://issues.apache.org/jira/browse/TEPHRA-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828943#comment-15828943 ] 

ASF GitHub Bot commented on TEPHRA-208:
---------------------------------------

Github user gokulavasan commented on the issue:

    https://github.com/apache/incubator-tephra/pull/26
  
    @twdsilva Curious why we need to use HDFSTransactionStateStorage to test this? Is there any problem with running it with the existing InMemoryTransactionStateStorage?


> Compaction removes rows incorrectly for family deletes with column level conflict detection 
> --------------------------------------------------------------------------------------------
>
>                 Key: TEPHRA-208
>                 URL: https://issues.apache.org/jira/browse/TEPHRA-208
>             Project: Tephra
>          Issue Type: Bug
>    Affects Versions: 0.9.0-incubating
>            Reporter: Thomas D'Silva
>            Assignee: Poorna Chandra
>         Attachments: TEPHRA-208.patch
>
>
> In DeleteTracker we only check the timestamp while removing cells during compaction. If the previous row had a family delete, cells from subsequent rows could also be compacted. 
> The attached test fails without the following change
> {code}
> private static final class DeleteTracker {
>      private long familyDeleteTs;
> +    private byte[] rowKey;
>  
>      public static boolean isFamilyDelete(Cell cell) {
>        return !TxUtils.isPreExistingVersion(cell.getTimestamp()) &&
> @@ -300,14 +301,17 @@ public class TransactionVisibilityFilter extends FilterBase {
>  
>      public void addFamilyDelete(Cell delete) {
>        this.familyDeleteTs = delete.getTimestamp();
> +      this.rowKey = Bytes.copy(delete.getRowArray(), delete.getRowOffset(), delete.getRowLength());
>      }
>  
>      public boolean isDeleted(Cell cell) {
> -      return cell.getTimestamp() <= familyDeleteTs;
> +      return rowKey != null && Bytes.compareTo(cell.getRowArray(), cell.getRowOffset(), 
> +        cell.getRowLength(), rowKey, 0, rowKey.length) == 0 && cell.getTimestamp() <= familyDeleteTs;
>      }
>  
>      public void reset() {
>        this.familyDeleteTs = 0;
> +      this.rowKey = null;
>      }
>    }
>  }
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)