From dev-return-643-apmail-tephra-dev-archive=tephra.apache.org@tephra.incubator.apache.org Wed Jan 18 01:26:46 2017 Return-Path: X-Original-To: apmail-tephra-dev-archive@minotaur.apache.org Delivered-To: apmail-tephra-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 700AC19089 for ; Wed, 18 Jan 2017 01:26:46 +0000 (UTC) Received: (qmail 51824 invoked by uid 500); 18 Jan 2017 01:26:45 -0000 Delivered-To: apmail-tephra-dev-archive@tephra.apache.org Received: (qmail 51784 invoked by uid 500); 18 Jan 2017 01:26:45 -0000 Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tephra.incubator.apache.org Delivered-To: mailing list dev@tephra.incubator.apache.org Received: (qmail 51768 invoked by uid 99); 18 Jan 2017 01:26:45 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Jan 2017 01:26:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 3B286C17FA for ; Wed, 18 Jan 2017 01:26:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.199 X-Spam-Level: X-Spam-Status: No, score=-1.199 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id KFwwAQHEwz-x for ; Wed, 18 Jan 2017 01:26:44 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 627375F576 for ; Wed, 18 Jan 2017 01:26:44 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id EC1E1E8669 for ; Wed, 18 Jan 2017 01:26:27 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 7B46325288 for ; Wed, 18 Jan 2017 01:26:26 +0000 (UTC) Date: Wed, 18 Jan 2017 01:26:26 +0000 (UTC) From: "James Taylor (JIRA)" To: dev@tephra.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (TEPHRA-208) Compaction removes rows incorrectly for family deletes with column level conflict detection MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/TEPHRA-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15827203#comment-15827203 ] James Taylor commented on TEPHRA-208: ------------------------------------- Ping [~poornachandra] & [~gokulavasan]. > Compaction removes rows incorrectly for family deletes with column level conflict detection > -------------------------------------------------------------------------------------------- > > Key: TEPHRA-208 > URL: https://issues.apache.org/jira/browse/TEPHRA-208 > Project: Tephra > Issue Type: Bug > Affects Versions: 0.9.0-incubating > Reporter: Thomas D'Silva > Assignee: Poorna Chandra > Attachments: TEPHRA-208.patch > > > In DeleteTracker we only check the timestamp while removing cells during compaction. If the previous row had a family delete, cells from subsequent rows could also be compacted. > The attached test fails without the following change > {code} > private static final class DeleteTracker { > private long familyDeleteTs; > + private byte[] rowKey; > > public static boolean isFamilyDelete(Cell cell) { > return !TxUtils.isPreExistingVersion(cell.getTimestamp()) && > @@ -300,14 +301,17 @@ public class TransactionVisibilityFilter extends FilterBase { > > public void addFamilyDelete(Cell delete) { > this.familyDeleteTs = delete.getTimestamp(); > + this.rowKey = Bytes.copy(delete.getRowArray(), delete.getRowOffset(), delete.getRowLength()); > } > > public boolean isDeleted(Cell cell) { > - return cell.getTimestamp() <= familyDeleteTs; > + return rowKey != null && Bytes.compareTo(cell.getRowArray(), cell.getRowOffset(), > + cell.getRowLength(), rowKey, 0, rowKey.length) == 0 && cell.getTimestamp() <= familyDeleteTs; > } > > public void reset() { > this.familyDeleteTs = 0; > + this.rowKey = null; > } > } > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)