From dev-return-678-apmail-tephra-dev-archive=tephra.apache.org@tephra.incubator.apache.org Mon Jan 23 22:55:02 2017 Return-Path: X-Original-To: apmail-tephra-dev-archive@minotaur.apache.org Delivered-To: apmail-tephra-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8D81C19EC7 for ; Mon, 23 Jan 2017 22:55:02 +0000 (UTC) Received: (qmail 99111 invoked by uid 500); 23 Jan 2017 22:55:02 -0000 Delivered-To: apmail-tephra-dev-archive@tephra.apache.org Received: (qmail 99072 invoked by uid 500); 23 Jan 2017 22:55:02 -0000 Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tephra.incubator.apache.org Delivered-To: mailing list dev@tephra.incubator.apache.org Received: (qmail 99059 invoked by uid 99); 23 Jan 2017 22:55:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Jan 2017 22:55:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id D24DF185F0B for ; Mon, 23 Jan 2017 22:55:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -7.019 X-Spam-Level: X-Spam-Status: No, score=-7.019 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id H0TqUrQrSBK2 for ; Mon, 23 Jan 2017 22:55:01 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 2F3345F610 for ; Mon, 23 Jan 2017 22:55:00 +0000 (UTC) Received: (qmail 96235 invoked by uid 99); 23 Jan 2017 22:54:00 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Jan 2017 22:54:00 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id D6E1FDFBE6; Mon, 23 Jan 2017 22:54:00 +0000 (UTC) From: poornachandra To: dev@tephra.incubator.apache.org Reply-To: dev@tephra.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-tephra pull request #28: TEPHRA-210 Get table specific properties ... Content-Type: text/plain Message-Id: <20170123225400.D6E1FDFBE6@git1-us-west.apache.org> Date: Mon, 23 Jan 2017 22:54:00 +0000 (UTC) Github user poornachandra commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/28#discussion_r97436585 --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java --- @@ -140,29 +141,25 @@ public void start(CoprocessorEnvironment e) throws IOException { ttlByFamily.put(columnDesc.getName(), ttl); } - this.allowEmptyValues = env.getConfiguration().getBoolean(TxConstants.ALLOW_EMPTY_VALUES_KEY, - TxConstants.ALLOW_EMPTY_VALUES_DEFAULT); + String allowEmptyValuesFromTableDesc = tableDesc.getValue(TxConstants.ALLOW_EMPTY_VALUES_KEY); + this.allowEmptyValues = (allowEmptyValuesFromTableDesc != null) ? Boolean.valueOf(allowEmptyValuesFromTableDesc) : + getConfiguration(env).getBoolean(TxConstants.ALLOW_EMPTY_VALUES_KEY, TxConstants.ALLOW_EMPTY_VALUES_DEFAULT); --- End diff -- Looks like `allowEmptyValues` was not a table level property before. Any reason why we made it into a table level property now? > If we do it lazily, then we might get different results for a Get operation based on whether we were able to read the Configuration successfully or not. If not then it can be initialized incorrectly during startup, and will always be wrong, right? I think it should always be read lazily. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---