tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TEPHRA-212) CompactionState #savePruneUpperBoundForRegion put call might because problems if regions are not available
Date Fri, 27 Jan 2017 02:23:24 GMT

    [ https://issues.apache.org/jira/browse/TEPHRA-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15840851#comment-15840851
] 

ASF GitHub Bot commented on TEPHRA-212:
---------------------------------------

Github user poornachandra commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/29#discussion_r98135660
  
    --- Diff: tephra-core/src/main/java/org/apache/tephra/TxConstants.java ---
    @@ -369,6 +369,12 @@
          * Interval in seconds to schedule prune run.
          */
         public static final String PRUNE_INTERVAL = "data.tx.prune.interval";
    +
    +    /**
    +     * Interval in seconds to schedule flush of prune table entries to store.
    +     */
    +    public static final String PRUNE_FLUSH_INTERVAL = "data.tx.prune.flush.interval";
    --- End diff --
    
    Looks like this is not used anywhere. Also I don't think we need this


> CompactionState #savePruneUpperBoundForRegion put call might because problems if regions
are not available
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: TEPHRA-212
>                 URL: https://issues.apache.org/jira/browse/TEPHRA-212
>             Project: Tephra
>          Issue Type: Bug
>    Affects Versions: 0.11.0-incubating
>            Reporter: Gokul Gunasekaran
>            Assignee: Gokul Gunasekaran
>             Fix For: 0.11.0-incubating
>
>
> If the regions corresponding to prune state table are not available, trying to do a put
to that table might cause multiple retries etc and might cause issues. Instead of doing this
write in a synchronous fashion, this should be done asynchronously.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message