tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From poornachandra <...@git.apache.org>
Subject [GitHub] incubator-tephra pull request #29: TEPHRA-212 Perform writes to prune state ...
Date Fri, 27 Jan 2017 02:23:02 GMT
Github user poornachandra commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/29#discussion_r98135416
  
    --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/CompactionState.java
---
    @@ -75,18 +76,34 @@ public void record(CompactionRequest request, @Nullable TransactionVisibilitySta
       }
     
       /**
    +   * Stops the current {@link PruneUpperBoundWriter}.
    +   */
    +  public void stop() {
    +    if (pruneUpperBoundWriter != null) {
    +      pruneUpperBoundWriter.stop();
    +    }
    +  }
    +
    +  /**
        * Persists the transaction state recorded by {@link #record(CompactionRequest, TransactionVisibilityState)}.
        * This method is called after the compaction has successfully completed.
        */
       public void persist() {
         if (pruneUpperBound != -1) {
    -      try {
    -        dataJanitorState.savePruneUpperBoundForRegion(regionName, pruneUpperBound);
    -        LOG.debug(String.format("Saved prune upper bound %s for region %s", pruneUpperBound,
regionNameAsString));
    -      } catch (IOException e) {
    -        LOG.warn(String.format("Cannot record prune upper bound in table %s after compacting
region %s",
    -                               stateTable, regionNameAsString), e);
    -      }
    +      PruneUpperBoundWriter upperBoundWriter = getPruneUpperBoundWriter();
    --- End diff --
    
    There are redundant instances of class `PruneUpperBoundWriter` => `upperBoundWriter`
and a`pruneUpperBoundWriter`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message