tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From poornachandra <...@git.apache.org>
Subject [GitHub] incubator-tephra pull request #28: TEPHRA-210 Get table specific properties ...
Date Wed, 25 Jan 2017 03:13:30 GMT
Github user poornachandra commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/28#discussion_r97702427
  
    --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java
---
    @@ -303,10 +305,22 @@ public InternalScanner preCompactScannerOpen(ObserverContext<RegionCoprocessorEn
         // Get the latest tx snapshot state for the compaction
         TransactionVisibilityState snapshot = cache.getLatestState();
     
    -    // Record tx state before the compaction
    -    if (compactionState != null) {
    +    if (pruneEnable == null) {
    +      Configuration conf = getConfiguration(c.getEnvironment());
    +      pruneEnable = conf.getBoolean(TxConstants.TransactionPruning.PRUNE_ENABLE,
    --- End diff --
    
    Since this code does not change between Tehpra and derived class implementation, we may
need to handle the case when configuration is not available after startup. What do you think?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message