tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gokulavasan <...@git.apache.org>
Subject [GitHub] incubator-tephra pull request #28: TEPHRA-210 Get table specific properties ...
Date Tue, 24 Jan 2017 21:55:03 GMT
Github user gokulavasan commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/28#discussion_r97660499
  
    --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java
---
    @@ -140,29 +141,25 @@ public void start(CoprocessorEnvironment e) throws IOException {
             ttlByFamily.put(columnDesc.getName(), ttl);
           }
     
    -      this.allowEmptyValues = env.getConfiguration().getBoolean(TxConstants.ALLOW_EMPTY_VALUES_KEY,
    -                                                                TxConstants.ALLOW_EMPTY_VALUES_DEFAULT);
    +      String allowEmptyValuesFromTableDesc = tableDesc.getValue(TxConstants.ALLOW_EMPTY_VALUES_KEY);
    +      this.allowEmptyValues = (allowEmptyValuesFromTableDesc != null) ? Boolean.valueOf(allowEmptyValuesFromTableDesc)
:
    +        getConfiguration(env).getBoolean(TxConstants.ALLOW_EMPTY_VALUES_KEY, TxConstants.ALLOW_EMPTY_VALUES_DEFAULT);
    --- End diff --
    
    I have updated the PR to read the value from table descriptor first. If it is not available
in the tableDescriptor, we try to obtain it from the configuration as we used to earlier.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message