tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From poornachandra <...@git.apache.org>
Subject [GitHub] incubator-tephra pull request #28: TEPHRA-210 Get table specific properties ...
Date Mon, 23 Jan 2017 22:54:00 GMT
Github user poornachandra commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/28#discussion_r97436585
  
    --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java
---
    @@ -140,29 +141,25 @@ public void start(CoprocessorEnvironment e) throws IOException {
             ttlByFamily.put(columnDesc.getName(), ttl);
           }
     
    -      this.allowEmptyValues = env.getConfiguration().getBoolean(TxConstants.ALLOW_EMPTY_VALUES_KEY,
    -                                                                TxConstants.ALLOW_EMPTY_VALUES_DEFAULT);
    +      String allowEmptyValuesFromTableDesc = tableDesc.getValue(TxConstants.ALLOW_EMPTY_VALUES_KEY);
    +      this.allowEmptyValues = (allowEmptyValuesFromTableDesc != null) ? Boolean.valueOf(allowEmptyValuesFromTableDesc)
:
    +        getConfiguration(env).getBoolean(TxConstants.ALLOW_EMPTY_VALUES_KEY, TxConstants.ALLOW_EMPTY_VALUES_DEFAULT);
    --- End diff --
    
    Looks like `allowEmptyValues` was not a table level property before. Any reason why we
made it into a table level property now?
    
    > If we do it lazily, then we might get different results for a Get operation based
on whether we were able to read the Configuration successfully or not.
    
    If not then it can be initialized incorrectly during startup, and will always be wrong,
right? I think it should always be read lazily. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message