From dev-return-572-apmail-tephra-dev-archive=tephra.apache.org@tephra.incubator.apache.org Thu Dec 8 08:35:03 2016 Return-Path: X-Original-To: apmail-tephra-dev-archive@minotaur.apache.org Delivered-To: apmail-tephra-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 01A2F19D76 for ; Thu, 8 Dec 2016 08:35:03 +0000 (UTC) Received: (qmail 53044 invoked by uid 500); 8 Dec 2016 08:35:03 -0000 Delivered-To: apmail-tephra-dev-archive@tephra.apache.org Received: (qmail 53006 invoked by uid 500); 8 Dec 2016 08:35:02 -0000 Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tephra.incubator.apache.org Delivered-To: mailing list dev@tephra.incubator.apache.org Received: (qmail 52990 invoked by uid 99); 8 Dec 2016 08:35:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Dec 2016 08:35:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id D185EC036F for ; Thu, 8 Dec 2016 08:35:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -7.018 X-Spam-Level: X-Spam-Status: No, score=-7.018 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id ulP-kv-nxnT1 for ; Thu, 8 Dec 2016 08:35:01 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 1A04D5F571 for ; Thu, 8 Dec 2016 08:34:59 +0000 (UTC) Received: (qmail 52953 invoked by uid 99); 8 Dec 2016 08:34:59 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Dec 2016 08:34:59 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 1A601E38F9; Thu, 8 Dec 2016 08:34:59 +0000 (UTC) From: anew To: dev@tephra.incubator.apache.org Reply-To: dev@tephra.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-tephra pull request #23: [Tephra-201] Store checkpoints in in-prog... Content-Type: text/plain Message-Id: <20161208083459.1A601E38F9@git1-us-west.apache.org> Date: Thu, 8 Dec 2016 08:34:59 +0000 (UTC) Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/23#discussion_r91466379 --- Diff: tephra-core/src/main/java/org/apache/tephra/TransactionManager.java --- @@ -917,6 +933,15 @@ private void doCommit(long transactionId, long writePointer, Set chang invalidArray = invalid.toLongArray(); LOG.info("Tx invalid list: removed committed tx {}", transactionId); } + } else { + long[] checkpointPointers = previous.getCheckpointWritePointers().toLongArray(); + if (checkpointPointers != null && checkpointPointers.length > 0) { --- End diff -- I can't find a away that this could be null. Changed it everywhere it is used to assume it is not null --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---