From dev-return-563-apmail-tephra-dev-archive=tephra.apache.org@tephra.incubator.apache.org Thu Dec 8 08:16:36 2016 Return-Path: X-Original-To: apmail-tephra-dev-archive@minotaur.apache.org Delivered-To: apmail-tephra-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4FCA119D03 for ; Thu, 8 Dec 2016 08:16:35 +0000 (UTC) Received: (qmail 18051 invoked by uid 500); 8 Dec 2016 08:16:35 -0000 Delivered-To: apmail-tephra-dev-archive@tephra.apache.org Received: (qmail 18018 invoked by uid 500); 8 Dec 2016 08:16:35 -0000 Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tephra.incubator.apache.org Delivered-To: mailing list dev@tephra.incubator.apache.org Received: (qmail 17925 invoked by uid 99); 8 Dec 2016 08:16:34 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Dec 2016 08:16:34 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id BCAABC172E for ; Thu, 8 Dec 2016 08:16:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -7.018 X-Spam-Level: X-Spam-Status: No, score=-7.018 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id cCuwTYjguto9 for ; Thu, 8 Dec 2016 08:16:33 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 154365F1B3 for ; Thu, 8 Dec 2016 08:16:31 +0000 (UTC) Received: (qmail 17835 invoked by uid 99); 8 Dec 2016 08:16:31 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Dec 2016 08:16:31 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 22A45E38F9; Thu, 8 Dec 2016 08:16:31 +0000 (UTC) From: chtyim To: dev@tephra.incubator.apache.org Reply-To: dev@tephra.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-tephra pull request #23: [Tephra-201] Store checkpoints in in-prog... Content-Type: text/plain Message-Id: <20161208081631.22A45E38F9@git1-us-west.apache.org> Date: Thu, 8 Dec 2016 08:16:31 +0000 (UTC) Github user chtyim commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/23#discussion_r91460925 --- Diff: tephra-core/src/main/java/org/apache/tephra/TransactionManager.java --- @@ -1319,20 +1344,60 @@ public void shutdown() { } /** + * Type of in-progress transaction. + */ + public enum InProgressType { + + /** + * Short transactions detect conflicts during commit. + */ + SHORT(TransactionType.SHORT), + + /** + * Long running transactions do not detect conflicts during commit. + */ + LONG(TransactionType.LONG), + + /** + * Check-pointed transactions are recorded as in-progress. + */ + CHECKPOINT(null); + + private final TransactionType transactionType; + + InProgressType(TransactionType transactionType) { + this.transactionType = transactionType; + } + + public static InProgressType of(TransactionType type) { + switch (type) { + case SHORT: return SHORT; + case LONG: return LONG; + default: throw new IllegalArgumentException("Unknown TransactionType " + type); + } + } + + @Nullable + public TransactionType getTransactionType() { + return transactionType; + } + } + + /** * Represents some of the info on in-progress tx */ public static final class InProgressTx { /** the oldest in progress tx at the time of this tx start */ private final long visibilityUpperBound; private final long expiration; - private final TransactionType type; + private final InProgressType type; private LongArrayList checkpointWritePointers = new LongArrayList(); --- End diff -- This should be a final field? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---