From dev-return-508-apmail-tephra-dev-archive=tephra.apache.org@tephra.incubator.apache.org Sat Dec 3 22:32:09 2016 Return-Path: X-Original-To: apmail-tephra-dev-archive@minotaur.apache.org Delivered-To: apmail-tephra-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1E87919B7B for ; Sat, 3 Dec 2016 22:32:09 +0000 (UTC) Received: (qmail 19074 invoked by uid 500); 3 Dec 2016 22:32:09 -0000 Delivered-To: apmail-tephra-dev-archive@tephra.apache.org Received: (qmail 18969 invoked by uid 500); 3 Dec 2016 22:32:08 -0000 Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tephra.incubator.apache.org Delivered-To: mailing list dev@tephra.incubator.apache.org Received: (qmail 18901 invoked by uid 99); 3 Dec 2016 22:32:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 03 Dec 2016 22:32:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 3E3781A0694 for ; Sat, 3 Dec 2016 22:32:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -7.018 X-Spam-Level: X-Spam-Status: No, score=-7.018 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 7pMJo-Th3Nc5 for ; Sat, 3 Dec 2016 22:32:06 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 66D9C5F369 for ; Sat, 3 Dec 2016 22:32:05 +0000 (UTC) Received: (qmail 18863 invoked by uid 99); 3 Dec 2016 22:32:04 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 03 Dec 2016 22:32:04 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 6BD65DFCC8; Sat, 3 Dec 2016 22:32:04 +0000 (UTC) From: anew To: dev@tephra.incubator.apache.org Reply-To: dev@tephra.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-tephra pull request #20: Compute global prune upper bound using co... Content-Type: text/plain Message-Id: <20161203223204.6BD65DFCC8@git1-us-west.apache.org> Date: Sat, 3 Dec 2016 22:32:04 +0000 (UTC) Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/20#discussion_r90766397 --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/janitor/HBaseTransactionPruningPlugin.java --- @@ -259,6 +262,8 @@ private long computePruneUpperBound(TimeRegions timeRegions) throws IOException if (pruneUpperBoundForTime != -1) { Long minPruneUpperBoundRegions = Collections.min(pruneUpperBoundRegions.values()); return Math.min(pruneUpperBoundForTime, minPruneUpperBoundRegions); + } else { + LOG.debug("Ignoring invalid prune upper bound -1 for time {}", time); } } else { if (LOG.isDebugEnabled()) { --- End diff -- Maybe the message here should also be rephrased: "Ignoring regions for time {} because not all of the regions recorded a pruneUpperBound." This may seem picky, but remember that these messages will be seen by devops who does not understand the internals. If you rephrase it this way, they will understand better what is gong on. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---