tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anew <...@git.apache.org>
Subject [GitHub] incubator-tephra pull request #23: [Tephra-201] Store checkpoints in in-prog...
Date Thu, 08 Dec 2016 08:34:59 GMT
Github user anew commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/23#discussion_r91466379
  
    --- Diff: tephra-core/src/main/java/org/apache/tephra/TransactionManager.java ---
    @@ -917,6 +933,15 @@ private void doCommit(long transactionId, long writePointer, Set<ChangeId>
chang
             invalidArray = invalid.toLongArray();
             LOG.info("Tx invalid list: removed committed tx {}", transactionId);
           }
    +    } else {
    +      long[] checkpointPointers = previous.getCheckpointWritePointers().toLongArray();
    +      if (checkpointPointers != null && checkpointPointers.length > 0) {
    --- End diff --
    
    I can't find a away that this could be null. Changed it everywhere it is used to assume
it is not null


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message