tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anew <...@git.apache.org>
Subject [GitHub] incubator-tephra pull request #22: Transaction pruning service
Date Wed, 07 Dec 2016 03:39:07 GMT
Github user anew commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/22#discussion_r91221430
  
    --- Diff: tephra-core/src/main/java/org/apache/tephra/TxConstants.java ---
    @@ -158,6 +158,14 @@
          * The default value for the transaction timeout limit, in seconds: unlimited.
          */
         public static final int DEFAULT_TX_MAX_TIMEOUT = Integer.MAX_VALUE;
    +    /**
    +     * The maximum time in seconds that a transaction can be used for data writes.
    --- End diff --
    
    Does this apply to all transaction, including long-running ones? I think it helps to say
that after this time, all writes to the table will fail, and that is ensured by Tephra's coprocessors.
    
    You should also document that this value influences invalid tx pruning. 
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message