tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anew <...@git.apache.org>
Subject [GitHub] incubator-tephra pull request #20: Compute global prune upper bound using co...
Date Sat, 03 Dec 2016 22:32:04 GMT
Github user anew commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/20#discussion_r90766397
  
    --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/janitor/HBaseTransactionPruningPlugin.java
---
    @@ -259,6 +262,8 @@ private long computePruneUpperBound(TimeRegions timeRegions) throws
IOException
             if (pruneUpperBoundForTime != -1) {
               Long minPruneUpperBoundRegions = Collections.min(pruneUpperBoundRegions.values());
               return Math.min(pruneUpperBoundForTime, minPruneUpperBoundRegions);
    +        } else {
    +          LOG.debug("Ignoring invalid prune upper bound -1 for time {}", time);
             }
           } else {
             if (LOG.isDebugEnabled()) {
    --- End diff --
    
    Maybe the message here should also be rephrased: "Ignoring regions for time {} because
not all of the regions recorded a pruneUpperBound."
    
    This may seem picky, but remember that these messages will be seen by devops who does
not understand the internals. If you rephrase it this way, they will understand better what
is gong on. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message