Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@tephra.incubator.apache.org
From: anew <git@git.apache.org>
To: dev@tephra.incubator.apache.org
Reply-To: dev@tephra.incubator.apache.org
References: <git-pr-20-incubator-tephra@git.apache.org>
In-Reply-To: <git-pr-20-incubator-tephra@git.apache.org>
Subject: [GitHub] incubator-tephra pull request #20: Compute global prune upper bound using co...
Content-Type: text/plain
Message-Id: <20161129043416.54855DF984@git1-us-west.apache.org>
Date: Tue, 29 Nov 2016 04:34:16 +0000 (UTC)
archived-at: Tue, 29 Nov 2016 04:34:23 -0000

Github user anew commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/20#discussion_r89938407
  
    --- Diff: tephra-core/src/main/java/org/apache/tephra/janitor/DataJanitorPlugin.java ---
    @@ -0,0 +1,59 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +package org.apache.tephra.janitor;
    +
    +import org.apache.hadoop.conf.Configuration;
    +
    +import java.io.IOException;
    +
    +/**
    + * Data janitor interface to manage the invalid transaction list.
    + * There will be one such plugin per data store that will be invoked periodically
    + * to fetch the prune upper bound for each data store.
    + * Invalid transaction list will pruned up to the minimum of prune upper bounds returned by all the plugins.
    + */
    +public interface DataJanitorPlugin {
    +  /**
    +   * Called once at the beginning to initialize the plugin
    +   */
    +  void initialize(Configuration conf) throws IOException;
    +
    +  /**
    +   * Called periodically to fetch prune upper bound for a data store
    +   *
    +   * @param time start time of this prune iteration
    +   * @param pruneUpperBoundForTime upper bound for prune tx id for the given start time
    --- End diff --
    
    this is confusing. I thought this _returns_ the prune upper bound? Why does it need the upper bound passed in as a parameter. I think you need to explain better what this parameter means. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---