tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anew <...@git.apache.org>
Subject [GitHub] incubator-tephra pull request #20: Compute global prune upper bound using co...
Date Tue, 29 Nov 2016 04:33:56 GMT
Github user anew commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/20#discussion_r89938666
  
    --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/janitor/DataJanitorState.java
---
    @@ -19,20 +19,46 @@
     
     package org.apache.tephra.hbase.coprocessor.janitor;
     
    +import com.google.common.collect.Maps;
    +import com.google.common.primitives.Longs;
    +import org.apache.hadoop.hbase.client.Delete;
     import org.apache.hadoop.hbase.client.Get;
     import org.apache.hadoop.hbase.client.Put;
    +import org.apache.hadoop.hbase.client.Result;
    +import org.apache.hadoop.hbase.client.ResultScanner;
    +import org.apache.hadoop.hbase.client.Scan;
     import org.apache.hadoop.hbase.client.Table;
     import org.apache.hadoop.hbase.util.Bytes;
     
     import java.io.IOException;
    +import java.util.Map;
    +import java.util.Set;
    +import java.util.SortedSet;
    +import java.util.TreeMap;
    +import java.util.TreeSet;
    +import javax.annotation.Nullable;
     
     /**
      * Persist data janitor state into an HBase table.
    --- End diff --
    
    Is it true that this class is shared between the DataJanitor coprocessor (for saving prune
state) and the DataJanitorPlugin in the tx manager (for reading the state)? If so, then this
deserves mentioning in the javadocs


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message