tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From poornachandra <...@git.apache.org>
Subject [GitHub] incubator-tephra pull request #19: TEPHRA-35 Save compaction state for pruni...
Date Mon, 07 Nov 2016 22:50:45 GMT
Github user poornachandra commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/19#discussion_r86888243
  
    --- Diff: tephra-core/src/main/java/org/apache/tephra/TxConstants.java ---
    @@ -345,4 +345,14 @@
         public static final byte CURRENT_VERSION = 3;
       }
     
    +  /**
    +   * Configuration for data janitor
    +   */
    +  public static final class DataJanitor {
    +    public static final String PRUNE_ENABLE = "data.tx.prune.enable";
    +    public static final String PRUNE_STATE_TABLE = "data.tx.prune.state.table";
    +
    +    public static final boolean DEFAULT_PRUNE_ENABLE = false;
    +    public static final String DEFAULT_PRUNE_STATE_TABLE = "default:data_tx_janitor_state";
    --- End diff --
    
    Good point, I removed the namespace from the default value. It can always be overridden
in the configuration


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message