Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@tephra.incubator.apache.org
Date: Thu, 20 Oct 2016 00:07:58 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@tephra.incubator.apache.org
Message-ID: <JIRA.13013020.1476744396000.34914.1476922078424@Atlassian.JIRA>
In-Reply-To: <JIRA.13013020.1476744396000@Atlassian.JIRA>
References: <JIRA.13013020.1476744396000@Atlassian.JIRA> <JIRA.13013020.1476744396629@arcas>
Subject: [jira] [Commented] (TEPHRA-194) Transaction client should not retry
 startShort() if an invalid timeout is given
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Thu, 20 Oct 2016 00:08:02 -0000


    [ https://issues.apache.org/jira/browse/TEPHRA-194?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1559=
0308#comment-15590308 ]=20

ASF GitHub Bot commented on TEPHRA-194:
---------------------------------------

GitHub user anew opened a pull request:

    https://github.com/apache/incubator-tephra/pull/18

    [TEPHRA-194] Make startShort() throw IllegalArgumentException =E2=80=A6

    =E2=80=A6 consistently for invalid timeout values.
   =20
    Previously, it was throwing IllegalArgumentException in-memory and Exce=
ption for thrift mode.=20
   =20
    This breaks down into:
    - adding a new exception to the thrift stubs to be able to communicate =
back any exception
    - adding a new method startShortWithTimeout that throws that exception
    - modifying the TransactionServiceThriftClient to convert that exceptio=
n back into an IllegalArgumentException
    - modifying the TransactionSystemTest to expect IllegalArgumentExceptio=
n now
    - modifying the ThriftTransactionServerTest to use a retry strategy tha=
t counts retries and validate that the number of retries is 0 if startShort=
() throws IllegalArgumentException
    - modifying TransactionServiceClient to accept a class name as the retr=
y strategy provider (needed for above test case)
    - some unrelated but reasonable style fixes
   =20
   =20


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anew/incubator-tephra tephra-194

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tephra/pull/18.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18
   =20
----
commit 64be9f46b8d3cc823d9eb303f9eb8ed7811375c7
Author: anew <anew@apache.org>
Date:   2016-10-19T23:59:33Z

    [TEPHRA-194] Make startShort() throw IllegalArgumentException consisten=
tly for invalid timeout values

----


> Transaction client should not retry startShort() if an invalid timeout is=
 given=20
> -------------------------------------------------------------------------=
-------
>
>                 Key: TEPHRA-194
>                 URL: https://issues.apache.org/jira/browse/TEPHRA-194
>             Project: Tephra
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.9.0-incubating, 0.10.0-incubating
>            Reporter: Andreas Neumann
>            Assignee: Andreas Neumann
>             Fix For: 0.10.0-incubating
>
>
> Currently, if an invalid timeout (negative, or too long) is given, the Tx=
 manager throws an IllegalArgumentException. The thrift client will catch t=
hat and apply the retry strategy. However, in this case, retry is pointless=
, and if the strategy is, for example, exponential backoff, if introduces u=
nneccessary load and latency.=20
> The service should instead throw a meaningful exception for that, so that=
 the client knows not to retry.=20


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)