Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 439F7200BB4 for ; Tue, 18 Oct 2016 01:02:05 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 42213160AF0; Mon, 17 Oct 2016 23:02:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8767B160AEC for ; Tue, 18 Oct 2016 01:02:04 +0200 (CEST) Received: (qmail 65717 invoked by uid 500); 17 Oct 2016 23:02:03 -0000 Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tephra.incubator.apache.org Delivered-To: mailing list dev@tephra.incubator.apache.org Received: (qmail 65706 invoked by uid 99); 17 Oct 2016 23:02:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Oct 2016 23:02:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 276531A070C for ; Mon, 17 Oct 2016 23:02:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -6.219 X-Spam-Level: X-Spam-Status: No, score=-6.219 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id TqTtd7dZGaoO for ; Mon, 17 Oct 2016 23:02:01 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id F33855FB16 for ; Mon, 17 Oct 2016 23:01:59 +0000 (UTC) Received: (qmail 65427 invoked by uid 99); 17 Oct 2016 23:01:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Oct 2016 23:01:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 1FA142C0059 for ; Mon, 17 Oct 2016 23:01:59 +0000 (UTC) Date: Mon, 17 Oct 2016 23:01:59 +0000 (UTC) From: "Andreas Neumann (JIRA)" To: dev@tephra.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (TEPHRA-194) Transaction client should not retry startShort() if an invalid timeout is given MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 17 Oct 2016 23:02:05 -0000 [ https://issues.apache.org/jira/browse/TEPHRA-194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Neumann updated TEPHRA-194: ----------------------------------- Description: Currently, if an invalid timeout (negative, or too long) is given, the Tx manager throws an IllegalArgumentException. The thrift client will catch that and apply the retry strategy. However, in this case, retry is pointless, and if the strategy is, for example, exponential backoff, if introduces unneccessary load and latency. The service should instead throw a meaningful exception for that, so that the client knows not to retry. was: Currently, if an invalid timeout (negative, or too long) is given, the Tx manager throws an IllegalArgumentException. The thrift client will catch that and apply the retry strategy. However, in this case, retry is pointless, and if the strategy is, for example, exponential backoff, if introduces unneccessary load and latency. The service should instead throw a meaningful exception that. > Transaction client should not retry startShort() if an invalid timeout is given > -------------------------------------------------------------------------------- > > Key: TEPHRA-194 > URL: https://issues.apache.org/jira/browse/TEPHRA-194 > Project: Tephra > Issue Type: Bug > Components: client > Affects Versions: 0.9.0-incubating, 0.10.0-incubating > Reporter: Andreas Neumann > Assignee: Andreas Neumann > Fix For: 0.10.0-incubating > > > Currently, if an invalid timeout (negative, or too long) is given, the Tx manager throws an IllegalArgumentException. The thrift client will catch that and apply the retry strategy. However, in this case, retry is pointless, and if the strategy is, for example, exponential backoff, if introduces unneccessary load and latency. > The service should instead throw a meaningful exception for that, so that the client knows not to retry. -- This message was sent by Atlassian JIRA (v6.3.4#6332)