Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@tephra.incubator.apache.org
MIME-Version: 1.0
Sender: neunand@gmail.com
In-Reply-To: <CAAF1JdjEEA2y5XXs0xHjhp5Juyre5u-ShoeQQst0KLY6vJ_MPQ@mail.gmail.com>
References: <CANpmDOdOYEAmWc8QHbV2qU4ue=xSr1cC8yCtVGu8wQ7KyvnEKQ@mail.gmail.com>
 <CAAF1JdjEEA2y5XXs0xHjhp5Juyre5u-ShoeQQst0KLY6vJ_MPQ@mail.gmail.com>
From: Andreas Neumann <anew@apache.org>
Date: Wed, 19 Oct 2016 11:43:50 -0700
Message-ID: <CANpmDOcbzM+8c3WNohV_06QuBMVrgY2=C7QXNhMeoRQScnNNmw@mail.gmail.com>
Subject: Re: What's our policy for Thrift changes?
To: dev@tephra.incubator.apache.org
Content-Type: multipart/alternative; boundary=001a11c28e98b00920053f3c309b
archived-at: Wed, 19 Oct 2016 18:49:13 -0000

--001a11c28e98b00920053f3c309b
Content-Type: text/plain; charset=UTF-8

Hi James,

I assume you are talking about a major release of Phoenix. We do have to
anticipate that improvements and new features in Tephra will require Thrift
changes. So what would be the process to coordinate that?
- Does it mean that Tephra cannot make changes unless a major Phoenix
release is expected?
- Or does it mean Phoenix will not pick up new Tephra releases until it has
a major release?

For TEPHRA-194, we can introduce a new method - say startShortWithTimeout()
- that throws the new exception, and change the TransactionServiceClient to
use that new method. Old clients will call the old method
startShortTimeout() and still work, but they won't get the improved
exception handling.

The question then is how long do we have to wait before we can remove the
old method?

Thanks -Andreas


On Mon, Oct 17, 2016 at 8:44 PM, James Taylor <jamestaylor@apache.org>
wrote:

> Hi Andreas,
> Phoenix can't assume that the client and server are the same version as we
> support rolling upgrades for patch and minor upgrades. It'd only be ok for
> a major release.
> Thanks,
> James
>
> On Monday, October 17, 2016, Andreas Neumann <anew@apache.org> wrote:
>
> > Hi all,
> >
> > As part of https://issues.apache.org/jira/browse/TEPHRA-194, it would
> make
> > sense to introduce a new exception type in the thrift module. That may
> > break wire compatibility with previous versions.
> >
> > I am wondering what the current policy is for changing the Thrift
> > protocol?Can we safely assume that - for now - the server and client will
> > always be the same version of Tephra?
> >
> > Cheers -Andreas
> >
>

--001a11c28e98b00920053f3c309b--