Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4649D200BB1 for ; Thu, 20 Oct 2016 02:19:25 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 44D75160AFB; Thu, 20 Oct 2016 00:19:25 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8B437160AEA for ; Thu, 20 Oct 2016 02:19:24 +0200 (CEST) Received: (qmail 71671 invoked by uid 500); 20 Oct 2016 00:19:23 -0000 Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tephra.incubator.apache.org Delivered-To: mailing list dev@tephra.incubator.apache.org Received: (qmail 71660 invoked by uid 99); 20 Oct 2016 00:19:23 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Oct 2016 00:19:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id AECED1A0656 for ; Thu, 20 Oct 2016 00:19:22 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -7.019 X-Spam-Level: X-Spam-Status: No, score=-7.019 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 2g5h5So_aQkg for ; Thu, 20 Oct 2016 00:19:21 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 862265F4E5 for ; Thu, 20 Oct 2016 00:19:20 +0000 (UTC) Received: (qmail 65077 invoked by uid 99); 20 Oct 2016 00:12:39 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Oct 2016 00:12:39 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 3FAACDFCF2; Thu, 20 Oct 2016 00:12:39 +0000 (UTC) From: anew To: dev@tephra.incubator.apache.org Reply-To: dev@tephra.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-tephra pull request #18: [TEPHRA-194] Make startShort() throw Ille... Content-Type: text/plain Message-Id: <20161020001239.3FAACDFCF2@git1-us-west.apache.org> Date: Thu, 20 Oct 2016 00:12:39 +0000 (UTC) archived-at: Thu, 20 Oct 2016 00:19:25 -0000 Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/18#discussion_r84193226 --- Diff: tephra-core/src/main/java/org/apache/tephra/distributed/thrift/TBoolean.java --- @@ -24,19 +24,29 @@ */ package org.apache.tephra.distributed.thrift; -import org.apache.thrift.EncodingUtils; --- End diff -- Note that thrift does not generate imports in the order that the checkstyle rules expect. The previous version of the generated thrift stubs was apparently manually changed to reflect the correct order and to have a copyright. For the copyright, I added an instruction how to add that to the README file, but for import order, we really should not fix that manually every time we run thrift. So we see a lot of diffs in the import section here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---