tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anew <...@git.apache.org>
Subject [GitHub] incubator-tephra pull request #18: [TEPHRA-194] Make startShort() throw Ille...
Date Thu, 20 Oct 2016 00:07:01 GMT
GitHub user anew opened a pull request:

    https://github.com/apache/incubator-tephra/pull/18

    [TEPHRA-194] Make startShort() throw IllegalArgumentException …

    … consistently for invalid timeout values.
    
    Previously, it was throwing IllegalArgumentException in-memory and Exception for thrift
mode. 
    
    This breaks down into:
    - adding a new exception to the thrift stubs to be able to communicate back any exception
    - adding a new method startShortWithTimeout that throws that exception
    - modifying the TransactionServiceThriftClient to convert that exception back into an
IllegalArgumentException
    - modifying the TransactionSystemTest to expect IllegalArgumentException now
    - modifying the ThriftTransactionServerTest to use a retry strategy that counts retries
and validate that the number of retries is 0 if startShort() throws IllegalArgumentException
    - modifying TransactionServiceClient to accept a class name as the retry strategy provider
(needed for above test case)
    - some unrelated but reasonable style fixes
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anew/incubator-tephra tephra-194

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tephra/pull/18.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18
    
----
commit 64be9f46b8d3cc823d9eb303f9eb8ed7811375c7
Author: anew <anew@apache.org>
Date:   2016-10-19T23:59:33Z

    [TEPHRA-194] Make startShort() throw IllegalArgumentException consistently for invalid
timeout values

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message