tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From poornachandra <...@git.apache.org>
Subject [GitHub] incubator-tephra pull request #18: [TEPHRA-194] Make startShort() throw Ille...
Date Thu, 20 Oct 2016 22:28:48 GMT
Github user poornachandra commented on a diff in the pull request:

    --- Diff: tephra-core/src/test/java/org/apache/tephra/ThriftTransactionSystemTest.java
    @@ -124,4 +127,39 @@ protected TransactionSystemClient getClient() throws Exception {
       protected TransactionStateStorage getStateStorage() throws Exception {
         return storage;
    +  @Override
    +  public void testNegativeTimeout() throws Exception {
    +    CountingRetryStrategyProvider.retries.set(0);
    +    super.testNegativeTimeout();
    +    Assert.assertEquals(0, CountingRetryStrategyProvider.retries.get());
    --- End diff --
    It would be good to add a comment on why the retries should be zero here.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message