tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anew <...@git.apache.org>
Subject [GitHub] incubator-tephra pull request #18: [TEPHRA-194] Make startShort() throw Ille...
Date Thu, 20 Oct 2016 00:12:39 GMT
Github user anew commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/18#discussion_r84193226
  
    --- Diff: tephra-core/src/main/java/org/apache/tephra/distributed/thrift/TBoolean.java
---
    @@ -24,19 +24,29 @@
      */
     package org.apache.tephra.distributed.thrift;
     
    -import org.apache.thrift.EncodingUtils;
    --- End diff --
    
    Note that thrift does not generate imports in the order that the checkstyle rules expect.
The previous version of the generated thrift stubs was apparently manually changed to reflect
the correct order and to have a copyright. For the copyright, I added an instruction how to
add that to the README file, but for import order, we really should not fix that manually
every time we run thrift. So we see a lot of diffs in the import section here. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message