tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From poornachandra <...@git.apache.org>
Subject [GitHub] incubator-tephra pull request #17: (TEPHRA-188) Allow to configure a limit f...
Date Thu, 06 Oct 2016 23:45:45 GMT
Github user poornachandra commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/17#discussion_r82304628
  
    --- Diff: tephra-core/src/main/java/org/apache/tephra/TransactionManager.java ---
    @@ -722,7 +725,10 @@ public Transaction startShort() {
        * @param timeoutInSeconds the time out period in seconds.
        */
       public Transaction startShort(int timeoutInSeconds) {
    -    Preconditions.checkArgument(timeoutInSeconds > 0, "timeout must be positive but
is %s", timeoutInSeconds);
    +    Preconditions.checkArgument(timeoutInSeconds > 0,
    +                                "timeout must be positive but is %s", timeoutInSeconds);
    +    Preconditions.checkArgument(timeoutInSeconds <= maxTimeout,
    +                                "timeout must not exceed %s but is %s", maxTimeout, timeoutInSeconds);
    --- End diff --
    
    It would be good to add the units here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message