Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@tephra.incubator.apache.org
Date: Thu, 22 Sep 2016 01:27:20 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@tephra.incubator.apache.org
Message-ID: <JIRA.13006711.1474506162000.633224.1474507640515@Atlassian.JIRA>
In-Reply-To: <JIRA.13006711.1474506162000@Atlassian.JIRA>
References: <JIRA.13006711.1474506162000@Atlassian.JIRA> <JIRA.13006711.1474506162774@arcas>
Subject: [jira] [Commented] (TEPHRA-185) TransactionContext should support a
 custom transaction timeout
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 22 Sep 2016 01:27:24 -0000


    [ https://issues.apache.org/jira/browse/TEPHRA-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15511762#comment-15511762 ] 

ASF GitHub Bot commented on TEPHRA-185:
---------------------------------------

Github user anew commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/14#discussion_r79965226
  
    --- Diff: tephra-core/src/main/java/org/apache/tephra/TransactionContext.java ---
    @@ -97,6 +127,7 @@ public void start() throws TransactionFailureException {
                                            txAware.getTransactionAwareName(), currentTx.getTransactionId());
             LOG.warn(message, e);
             txClient.abort(currentTx);
    +        currentTx = null;
    --- End diff --
    
    this is not strictly part of this new feature. Just fixing this along the way. Normally, after we abort the tx, we set currentTx = null. I thought it would be best to do that here, too 


> TransactionContext should support a custom transaction timeout
> --------------------------------------------------------------
>
>                 Key: TEPHRA-185
>                 URL: https://issues.apache.org/jira/browse/TEPHRA-185
>             Project: Tephra
>          Issue Type: Improvement
>          Components: core
>            Reporter: Andreas Neumann
>            Assignee: Andreas Neumann
>
> TransactionSystemClient has a startShort(timeout). TransactionContext should allow to specify a timeout, too.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)