Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@tephra.incubator.apache.org
From: anew <git@git.apache.org>
To: dev@tephra.incubator.apache.org
Reply-To: dev@tephra.incubator.apache.org
References: <git-pr-14-incubator-tephra@git.apache.org>
In-Reply-To: <git-pr-14-incubator-tephra@git.apache.org>
Subject: [GitHub] incubator-tephra pull request #14: (TEPHRA-185) Add a way to pass a custom t...
Content-Type: text/plain
Message-Id: <20160922012638.3BF9EE04D9@git1-us-west.apache.org>
Date: Thu, 22 Sep 2016 01:26:38 +0000 (UTC)
archived-at: Thu, 22 Sep 2016 01:26:43 -0000

Github user anew commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/14#discussion_r79965226
  
    --- Diff: tephra-core/src/main/java/org/apache/tephra/TransactionContext.java ---
    @@ -97,6 +127,7 @@ public void start() throws TransactionFailureException {
                                            txAware.getTransactionAwareName(), currentTx.getTransactionId());
             LOG.warn(message, e);
             txClient.abort(currentTx);
    +        currentTx = null;
    --- End diff --
    
    this is not strictly part of this new feature. Just fixing this along the way. Normally, after we abort the tx, we set currentTx = null. I thought it would be best to do that here, too 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---