Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@tephra.incubator.apache.org
From: chtyim <git@git.apache.org>
To: dev@tephra.incubator.apache.org
Reply-To: dev@tephra.incubator.apache.org
References: <git-pr-10-incubator-tephra@git.apache.org>
In-Reply-To: <git-pr-10-incubator-tephra@git.apache.org>
Subject: [GitHub] incubator-tephra pull request #10: TEPHRA-179 Transaction service high avail...
Content-Type: text/plain
Message-Id: <20160912163030.83324DFD4C@git1-us-west.apache.org>
Date: Mon, 12 Sep 2016 16:30:30 +0000 (UTC)
archived-at: Mon, 12 Sep 2016 16:30:36 -0000

Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/10#discussion_r78406297
  
    --- Diff: tephra-core/src/main/java/org/apache/tephra/distributed/TransactionService.java ---
    @@ -42,28 +45,64 @@
     import java.util.concurrent.ExecutionException;
     import java.util.concurrent.TimeUnit;
     import java.util.concurrent.TimeoutException;
    +import javax.annotation.Nullable;
     
     /**
      *
      */
    -public final class TransactionService extends InMemoryTransactionService {
    +public class TransactionService extends AbstractService {
       private static final Logger LOG = LoggerFactory.getLogger(TransactionService.class);
       private LeaderElection leaderElection;
       private final ZKClient zkClient;
    +  private final DiscoveryService discoveryService;
    +  private final Provider<TransactionManager> txManagerProvider;
     
    +  private final String serviceName;
    +  private Cancellable cancelDiscovery;
    +
    +  // thrift server config
    +  private final String address;
    +  private final int port;
    +  private final int threads;
    +  private final int ioThreads;
    +  private final int maxReadBufferBytes;
    +
    +  private TransactionManager txManager;
       private ThriftRPCServer<TransactionServiceThriftHandler, TTransactionServer> server;
     
       @Inject
       public TransactionService(Configuration conf,
                                 ZKClient zkClient,
                                 DiscoveryService discoveryService,
                                 Provider<TransactionManager> txManagerProvider) {
    -    super(conf, discoveryService, txManagerProvider);
         this.zkClient = zkClient;
    +    this.discoveryService = discoveryService;
    +    this.txManagerProvider = txManagerProvider;
    +
    +    serviceName = conf.get(TxConstants.Service.CFG_DATA_TX_DISCOVERY_SERVICE_NAME,
    +                           TxConstants.Service.DEFAULT_DATA_TX_DISCOVERY_SERVICE_NAME);
    +
    +    address = conf.get(TxConstants.Service.CFG_DATA_TX_BIND_ADDRESS, TxConstants.Service.DEFAULT_DATA_TX_BIND_ADDRESS);
    +    port = conf.getInt(TxConstants.Service.CFG_DATA_TX_BIND_PORT, TxConstants.Service.DEFAULT_DATA_TX_BIND_PORT);
    +
    +    // Retrieve the number of threads for the service
    +    threads = conf.getInt(TxConstants.Service.CFG_DATA_TX_SERVER_THREADS,
    +                          TxConstants.Service.DEFAULT_DATA_TX_SERVER_THREADS);
    +    ioThreads = conf.getInt(TxConstants.Service.CFG_DATA_TX_SERVER_IO_THREADS,
    +                            TxConstants.Service.DEFAULT_DATA_TX_SERVER_IO_THREADS);
    +
    +    maxReadBufferBytes = conf.getInt(TxConstants.Service.CFG_DATA_TX_THRIFT_MAX_READ_BUFFER,
    +                                     TxConstants.Service.DEFAULT_DATA_TX_THRIFT_MAX_READ_BUFFER);
    +
    +    LOG.info("Configuring TransactionService" +
    --- End diff --
    
    Use the `{}` syntax instead of `+`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---