From dev-return-170-apmail-tephra-dev-archive=tephra.apache.org@tephra.incubator.apache.org Wed Sep 7 21:28:58 2016 Return-Path: X-Original-To: apmail-tephra-dev-archive@minotaur.apache.org Delivered-To: apmail-tephra-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7E9B919FEB for ; Wed, 7 Sep 2016 21:28:58 +0000 (UTC) Received: (qmail 7110 invoked by uid 500); 7 Sep 2016 21:28:58 -0000 Delivered-To: apmail-tephra-dev-archive@tephra.apache.org Received: (qmail 7080 invoked by uid 500); 7 Sep 2016 21:28:58 -0000 Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tephra.incubator.apache.org Delivered-To: mailing list dev@tephra.incubator.apache.org Delivered-To: moderator for dev@tephra.incubator.apache.org Received: (qmail 62360 invoked by uid 99); 7 Sep 2016 20:41:58 -0000 X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.446 X-Spam-Level: X-Spam-Status: No, score=-5.446 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled From: poornachandra To: dev@tephra.incubator.apache.org Reply-To: dev@tephra.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-tephra pull request #2: TEPHRA-179 Create a new instance of Transa... Content-Type: text/plain Message-Id: <20160907204152.CB19BE03CE@git1-us-west.apache.org> Date: Wed, 7 Sep 2016 20:41:52 +0000 (UTC) Github user poornachandra commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/2#discussion_r77899606 --- Diff: tephra-core/src/main/java/org/apache/tephra/runtime/TransactionDistributedModule.java --- @@ -41,14 +41,15 @@ @Override protected void configure() { + // some of these classes need to be non-singleton in order to create a new instance during leader() in + // TransactionService bind(SnapshotCodecProvider.class).in(Singleton.class); - bind(TransactionStateStorage.class).annotatedWith(Names.named("persist")) - .to(HDFSTransactionStateStorage.class).in(Singleton.class); - bind(TransactionStateStorage.class).toProvider(TransactionStateStorageProvider.class).in(Singleton.class); + bind(TransactionStateStorage.class).annotatedWith(Names.named("persist")).to(HDFSTransactionStateStorage.class); + bind(TransactionStateStorage.class).toProvider(TransactionStateStorageProvider.class); - bind(TransactionManager.class).in(Singleton.class); - bind(TransactionSystemClient.class).to(TransactionServiceClient.class).in(Singleton.class); - bind(MetricsCollector.class).to(DefaultMetricsCollector.class).in(Singleton.class); + bind(TransactionManager.class); --- End diff -- This binding looks redundant now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---