tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gokul Gunasekaran <go...@apache.org>
Subject Re: Migrate Tephra codebase to Apache Tephra
Date Wed, 11 May 2016 18:33:17 GMT
Poorna,

The last two commits looks good to me.

Thanks,
Gokul

On Tue, May 10, 2016 at 9:52 PM, Poorna Chandra <poorna@apache.org> wrote:

> >
> > Would it be possible to only deprecate the old name "cask.*" property
> names
> > by looking for the new one first and falling back to the old one if not
> > found? That way, existing clients will continue to work when the server
> is
> > upgraded.
>
>
> Thanks for catching this James. From now on we need to support older
> clients.
>
> I have updated the code in the brach to reflect the review comments. Can
> you take a look at the last two commits?
>
> Thanks,
> Poorna.
>
>
> On Mon, May 9, 2016 at 3:27 PM, James Taylor <jamestaylor@apache.org>
> wrote:
>
> > bq. Since it kind of serves a purpose, I'll leave the developer list
> as-is
> > if others are not in favor of removing it.
> >
> > Sure, sounds good to me.
> >
> > Here's some more feedback:
> >
> > Would it be possible to only deprecate the old name "cask.*" property
> names
> > by looking for the new one first and falling back to the old one if not
> > found? That way, existing clients will continue to work when the server
> is
> > upgraded.
> >
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=incubator-tephra.git;a=blobdiff;f=tephra-core/src/main/java/org/apache/tephra/TxConstants.java;h=d9624867c5f30c63ba9a1790fd70030196f3ca9a;hp=7f7fc8c47c6589509eac6145c3eebad3542d2ede;hb=d038cb300ac603ae103eb1ae060aa84e3e9d7eb6;hpb=26ca8e1ac8f99b902fb9effef4faebe174543ff1
> >
> > Thanks for the quick work on this, Poorna. Everything else looks great.
> >
> >     James
> >
> >
> > On Mon, May 9, 2016 at 1:18 PM, Poorna Chandra <poorna@apache.org>
> wrote:
> >
> > > >
> > > > FWIW, HBase has the developer list in the pom.  This makes for a nice
> > > flow
> > > > when a new committer is added -- the first task for the new committer
> > is
> > > to
> > > > add themselves to the developer list.  This makes sure that commit
> > karma
> > > is
> > > > working right away and also makes the list self-maintaining.
> > > >
> > >
> > >
> > > But if others want to drop it here, that is fine by me as well.
> > >
> > >
> > > Since it kind of serves a purpose, I'll leave the developer list as-is
> if
> > > others are
> > > not in favor of removing it.
> > >
> > > Poorna.
> > >
> > > On Mon, May 9, 2016 at 12:43 PM, Gary Helmling <ghelmling@gmail.com>
> > > wrote:
> > >
> > > > >
> > > > > > - I've never seen the developers listed in the pom - that seems
> > hard
> > > to
> > > > > > maintain. IMHO, I'd just remove it entirely.
> > > > > >
> > > > >
> > > > > Makes sense, will remove it.
> > > > >
> > > > >
> > > > >
> > > > FWIW, HBase has the developer list in the pom.  This makes for a nice
> > > flow
> > > > when a new committer is added -- the first task for the new committer
> > is
> > > to
> > > > add themselves to the developer list.  This makes sure that commit
> > karma
> > > is
> > > > working right away and also makes the list self-maintaining.
> > > >
> > > > But if others want to drop it here, that is fine by me as well.
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message