tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Poorna Chandra <poo...@apache.org>
Subject Re: Please review backward compatibility changes
Date Fri, 13 May 2016 00:59:14 GMT
Changes look good Gokul.

Can you deprecate the newly added compatibility classes saying they
are needed only for the transition?

Thanks,
Poorna.


On Thu, May 12, 2016 at 2:48 PM, James Taylor <jamestaylor@apache.org>
wrote:

> Thanks, Henry! If you have any contacts at infra, maybe you could get an
> idea of when they might be able to get to the other ones?
>
>
> On Thu, May 12, 2016 at 2:46 PM, Henry Saputra <henry.saputra@gmail.com>
> wrote:
>
> > Ah cool, thanks for the update, James!
> >
> > As for INFRA-11695, I could try if I have access to do it.
> >
> > - Henry
> >
> > On Thu, May 12, 2016 at 2:44 PM, James Taylor <jamestaylor@apache.org>
> > wrote:
> >
> > > We're waiting on INFRA for GitHub integration INFRA-11448, and JIRA
> setup
> > > (INFRA-11445), and no ones sure how to do INFRA-11695 (maybe you know?)
> > so
> > > that INFRA can proceed with setting up svnpubsub for the website
> > > (INFRA-11447).
> > >
> > > On Thu, May 12, 2016 at 2:34 PM, Henry Saputra <
> henry.saputra@gmail.com>
> > > wrote:
> > >
> > > > Shall we enable advance Github integration for Tephra ASF Git repo to
> > > > enable PR for code review?
> > > >
> > > > Probably easier than reading diff online.
> > > >
> > > > - Henry
> > > >
> > > > On Thu, May 12, 2016 at 2:29 PM, Gokul Gunasekaran <
> > > gokulavasan@gmail.com>
> > > > wrote:
> > > >
> > > > > Hi,
> > > > >
> > > > > I have copied couple of classes related to TransactionEdit which
> has
> > > the
> > > > > old cask package name for backward compatibility.
> > > > >
> > > > > I have also bumped up the TransactionLog current version to 3 which
> > > > > represents logs written with the new apache package names. And the
> > > > previous
> > > > > versions are expected to be written with the old cask package
> names.
> > > Now
> > > > > the previous TransactionLogReaders expect the old cask package
> names
> > > and
> > > > > they convert it to new TransactionEdit (with apache package name)
> > when
> > > > they
> > > > > return the read object.
> > > > >
> > > > > Also enhanced the unit test to make sure we can read the new
> > > > > TransactionEdits (apache package) from logs written with old
> > versions -
> > > > 1,
> > > > > 2 (cask package) as well as new version 3 (apache package).
> > > > >
> > > > > The old classes, as discussed before, will be removed in the
> upcoming
> > > > > releases.
> > > > >
> > > > > Please review commit:
> > > > >
> > > > >
> > > >
> > >
> >
> https://git1-us-west.apache.org/repos/asf?p=incubator-tephra.git;a=commit;h=afe31fb6
> > > > >
> > > > > Thanks,
> > > > > Gokul
> > > > >
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message