From users-return-115291-archive-asf-public=cust-asf.ponee.io@tapestry.apache.org Fri Jul 12 13:03:19 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9C4421802C7 for ; Fri, 12 Jul 2019 15:03:19 +0200 (CEST) Received: (qmail 83544 invoked by uid 500); 12 Jul 2019 13:03:18 -0000 Mailing-List: contact users-help@tapestry.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tapestry users" Delivered-To: mailing list users@tapestry.apache.org Received: (qmail 83532 invoked by uid 99); 12 Jul 2019 13:03:18 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Jul 2019 13:03:18 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 91C52C2E8F for ; Fri, 12 Jul 2019 13:03:17 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.501 X-Spam-Level: ** X-Spam-Status: No, score=2.501 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=2, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=nesluop-dk.20150623.gappssmtp.com Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id emf3qLwpOmHu for ; Fri, 12 Jul 2019 13:03:15 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::941; helo=mail-ua1-x941.google.com; envelope-from=mailinglist@nesluop.dk; receiver= Received: from mail-ua1-x941.google.com (mail-ua1-x941.google.com [IPv6:2607:f8b0:4864:20::941]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id 706647E20D for ; Fri, 12 Jul 2019 13:03:15 +0000 (UTC) Received: by mail-ua1-x941.google.com with SMTP id c4so3969803uad.1 for ; Fri, 12 Jul 2019 06:03:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nesluop-dk.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=U/60YkUjofqgaWbTRl6/785HlKmW9fW4plh94TzBD24=; b=Gva+6Ind1ugRuq81eIvoPWix4rtZMf128BvtyAG82UvPWDgipLH4tmXd6WSUJkPo31 umKa/RAL9MT5vt4+DRXrDGEPpOkF9tYS4mBGO1a3eAv97fnbxU7fm03fMPOrHl/1pamV sj6GPhlxVdhWxHBRbBMI5FML1vsref0sGBL98P7PiXISHHp3y5r4B5osHC1oE1upSAdl kJjE0Mu8U532G4jsDPnfyucLp/wPhsUQmS/Nf0nj4Rsxw1XvrzqRT1RAGmQ7xu2jtkEL /OBM3hjYIbkz8Q6jguibuHMy9V3lh5hig9Xm2z689+8REI+A/+jhZhnwOmbA0fOZSs5B dLMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=U/60YkUjofqgaWbTRl6/785HlKmW9fW4plh94TzBD24=; b=blJm5F+W0tSDnCLvdDD4kU56yxSAiq6W84sbOf/+VOtJr14fIoHP0etd0nLAsZVj5V VkHO/VV/UYxX0uGv8yfuamcl97lE/fPVPxBffFWlD/xXi8eSjk3ynFkzC/l4UBessexS 8rz8O6IO/ZnL/B9vUFDUUhp+cDEbOHH07GAZTnzFdaIIIYGixzD8oP5QGeDEC4ne0qUO S9WFQSuGB1gM6g23rx8t8aO4m4WMVn8F2j8fZzXz5q1ehqoo7tm+rRx+uW3wfgvAp99c z9SIS0qyjp/ZH8nATDr+gqm1DFj08RZ4V0QSjscHzOq1nnLhlvdQQoUo4sioF7uH28Lz MKDQ== X-Gm-Message-State: APjAAAXIZuB29IWhiEvDYr1BQHwmY7tz/OuoZeI0QPiBzwndqCSRD/uC 326nsSGZs1pCBvHSwcSPTtuZaJrLnStzRGEVdERX3iTCXI9VmQ== X-Google-Smtp-Source: APXvYqwFymh7KlfMAMt1iRe15BTuCH5+MdIOiDLXDnUEng7LczT6lMSAZ3dn/fXnyN9TH8Jzr92NWn/n+GJYiRYa9Os= X-Received: by 2002:ab0:208c:: with SMTP id r12mr3062100uak.27.1562936593732; Fri, 12 Jul 2019 06:03:13 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Chris Poulsen Date: Fri, 12 Jul 2019 15:03:03 +0200 Message-ID: Subject: Re: Proxying default methods does not work with 5.5.0-beta-2 To: Tapestry users Content-Type: multipart/alternative; boundary="00000000000079f354058d7b882d" --00000000000079f354058d7b882d Content-Type: text/plain; charset="UTF-8" Hi I've just gotten around to test our products against Tapestry 5.5 (master/HEAD) - Everything seems to work fine with the latest code, good work! Would it be possible to get a tagged beta (or rc) version published to some repository that we can rely on for stable builds? I can see several 5.4 beta/rc versions in central ( https://mvnrepository.com/artifact/org.apache.tapestry/tapestry-core ), that would work well for us. I can see a single 5.4-beta on apache staging, but it seems unclear how long we can expect things to be present in "staging". -- Chris On Sat, Jun 22, 2019 at 3:43 AM Thiago H. de Paula Figueiredo < thiagohp@gmail.com> wrote: > I've just committed a fix for this issue. > > On Mon, May 6, 2019 at 2:35 PM Oliver Kaiser > wrote: > > > Hi everyone, > > > > given something like this: > > > > public interface Blub { > > public default String foo() { > > return "Default"; > > } > > } > > public class BlubImpl implements Blub { > > @Override > > public String foo() { > > return "Impl"; > > } > > } > > > > when calling "registry.getService(Blub.class).foo()" using beta-1 this > > works as expected (BlubImpl is called); when using beta-2 only the > > default method is called. > > > > the log output of PlasticProxyFactory shows that the method is skipped > > in the generated class > > > > seems to be related to this commit > > > > > https://github.com/apache/tapestry-5/commit/709d282bfc626ce55cde07cbf909c0b86c2b4bcb#diff-89a017b694cffee07e15608bc316d0d7 > > > > now "proxyInterface(Class, PlasticMethod)" only > > calls "introduceInterface(Class, PasticMethod)" (which skips the method > > as "isDefaultMethod(m)" returns true); earlier versions had an > > additional for-loop which handled this case (at least from stepping > > though in a debugger it looks that way) > > > > > > that's a regression, right? > > > > > > btw: thanks to everyone who worked on the 5.4->5.5 transition; updating > > was very smooth! > > > > > > Regards, > > Oliver > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: users-unsubscribe@tapestry.apache.org > > For additional commands, e-mail: users-help@tapestry.apache.org > > > > > > -- > Thiago > --00000000000079f354058d7b882d--