From dev-return-15720-archive-asf-public=cust-asf.ponee.io@syncope.apache.org Fri Jun 1 08:35:29 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E4E2118063A for ; Fri, 1 Jun 2018 08:35:28 +0200 (CEST) Received: (qmail 2057 invoked by uid 500); 1 Jun 2018 06:35:28 -0000 Mailing-List: contact dev-help@syncope.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@syncope.apache.org Delivered-To: mailing list dev@syncope.apache.org Received: (qmail 2046 invoked by uid 99); 1 Jun 2018 06:35:27 -0000 Received: from mail-relay.apache.org (HELO mailrelay1-lw-us.apache.org) (207.244.88.152) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Jun 2018 06:35:27 +0000 Received: from [192.168.0.3] (93-34-9-207.ip47.fastwebnet.it [93.34.9.207]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id A11B4CC5 for ; Fri, 1 Jun 2018 06:35:26 +0000 (UTC) Subject: Re: JavaEE connection pool removeAbandoned setting To: dev@syncope.apache.org References: <0bf1dd0f-5df1-6945-cc9d-fc3048d14edf@wimmel.net> From: =?UTF-8?Q?Francesco_Chicchiricc=c3=b2?= Openpgp: preference=signencrypt Autocrypt: addr=ilgrosso@apache.org; prefer-encrypt=mutual; keydata= xsBNBE9EncsBCAC02uAixULU/lI6u7y2a4hPLZ+J9eb1ZNVrg4iockEktP39C8zsve4rxltc 9SnT5wa2XwVTwiSl8HjxFGmc/CyMP4l+JLYLqAxvN25BXzoC7pvIpH5VcXMnTKP2bqIcIQ3H bR2gLxjxlEzRBgmzsnrtNWhlCi4DNuUcarMrzaWbQkW5DiieW/V7BNEKw7L/WESXWbXTC9zj vyf9JQ/Ql3ys7n7y+/C7nnnnRys9kJahJkYbiLasJTxRMm/ENjzwamE1s2khxNDhYXmeXyUf PYDv46rVP39TNNbecG9EuHbZZ1pRRSkGZJZnpWBu0O6VWOfn0aF2rR5mfbGHsQA8CQWlABEB AAHNOEZyYW5jZXNjbyBDaGljY2hpcmljY8OyIChpbGdyb3NzbykgPGlsZ3Jvc3NvQGFwYWNo ZS5vcmc+wsB4BBMBAgAiBQJPRJ3LAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRBr QxPtJz3yh5j3B/46VEpC62uq3wiwDaUYI2fl6DYjlAuSGbI9Q7Avxpz+yDieaPE7Q3C19Xx+ wTFrHyPOswbltmT5KDNqEpe5C9IpqoSyu7UIkqHtlXTxhsu+rFWpfABnI4sfQ0ui1VOLN3JB xG7G8PHCmIdYThSCRoM14u4KSU1ytd3SFtOpNLVU5TVBGm+aJWOu++XPSICn97101ndn8AJm JDTlHQwqMzpQTejLQnv020SouLq5cB2O6HSuSmSDpctFCdYkYLzHA6p3WzKgVXt9c3CV7Zhf w/XufaqXQQIkr1VLN/l13PlbPPnLluzPO+agDuCsJReFzF2JwxJYBLUIu0T8A+yrfTIzzsBN BE9EncsBCADQrFXb7lIhSSaTIkNnE987DGgLn9QRUEvSa+132lWcZYx+knLehdH0++F/cqUc 2KT17anzbOidGo0rvxwj5s42NV3lOUWIFBM7pUCwN2ef2CM3TVwA+/WrKGRFq/+cwAhSfDoc jtN4+vYd4NbIgzSA7ZuoaT4vKRpBex0fAN2J8tLOzXSbXdsoWRj4pVBnJ0N6WHRlaqLQnQ7o F1E6ZrNREMWasjxRuZ38mlpfbArnqw+lAbHL6T/BsKXOEjASe5iOPN9r95HW6dH1vmef1mOk /Pu6wr+eIcqwPIBUQRvHw5UnOrMugUf1ohgnx2NvggLOSlvgGBnZo47MphpOd5DVABEBAAHC wF8EGAECAAkFAk9EncsCGwwACgkQa0MT7Sc98oeFHggAro4b3tGyKCV7tMz8q9drqigl/6n+ /2riaumndUcPFZOsewDmg/75jszjc6hoe7wreBkJi0u8kvm6F0RpIlGk5WpCa7bljEc6Erm9 GLON/DoYn1MSpdMZdwucairqvMK1YWg/7wI/xjgq6br5FBoLegVE8bd3Iy4SVWKUIRURBF7q Ft3rVRUJdcmqHvCWpxDJ1VKPRDHf5szVkWXFJI0xiU6KuICWidZ9Hg3WXUsm3SePD7FtokiK 0Y9SBzHpd9EZe8KRIHekl5gVS2Xe83GC5GvPHEXE0usYUNRDArOXqIkGUCWHZ7gzueMBcWqW x+uxeS7bQfZZO/7ew7lIDf4gYA== Message-ID: <52978dc3-a0b8-f847-ac3c-0d5a2a406fed@apache.org> Date: Fri, 1 Jun 2018 08:35:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <0bf1dd0f-5df1-6945-cc9d-fc3048d14edf@wimmel.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US On 31/05/2018 19:30, Guido Wimmel wrote: > Hi Francesco, > > Am 30.05.2018 um 11:11 schrieb Francesco Chicchiriccò: >> On 29/05/2018 20:36, Guido Wimmel wrote: >>> Hi, >>> >>> the recommended JavaEE configuration example on >>> http://syncope.apache.org/docs/reference-guide.html#javaee-container >>> contains >>> >>> >>> >>> Is this intentional? Seems strange to me, as this setting is in >>> seconds (corresponding to more than 5 hours), according to >>> https://tomcat.apache.org/tomcat-8.5-doc/jdbc-pool.html >>> >>> Seems to have been introduced long ago in >>> https://issues.apache.org/jira/browse/SYNCOPE-61 , which talks about >>> milliseconds. >>> >>> Or do I overlook something here? >> >> Hi Guido, >> it seems you're right. >> >> I would say that we should replace 20000 with 20. >> (I must admit that since when we introduced HikariCP I am not >> regularly using the Tomcat DBCP, not even in production). >> >> Would you like to take care of such change both in >> >> https://cwiki.apache.org/confluence/display/SYNCOPE/Run+Syncope+in+real+environments#RunSyncopeinrealenvironments-context.xml >> >> >> and >> >> https://github.com/apache/syncope/blob/2_0_X/src/main/asciidoc/reference-guide/workingwithapachesyncope/systemadministration/javaeecontainer.adoc >> >> >> ? >> Regards. > > Sure, I can make the changes. > Default in Tomcat is 60. 20 might also be appropriate as a > recommendation if there are no long running queries. > > To be sure: the change in git should really be in the 2_0_X branch of > https://git-wip-us.apache.org/repos/asf/syncope.git , right? Correct: I tend to provide GitHub links because the content looks more appealing and navigable in the browser, but as we don't (currently?) use gitbox [1], we push to git-wip-us.apache.org and github gets updated too. Once committed to the 2_0_X branch, you could cherry-pick that commit to the master branch. At that point, you might want to have * https://ci.apache.org/projects/syncope/2_0_X/reference-guide.html * https://ci.apache.org/projects/syncope/master/reference-guide.html updated: if so, either wait for about 24 hours, or join IRC [2] and send the following messages: * syncope-bot: force build syncope-2_0_X-docs * syncope-bot: force build syncope-master-docs > Any requirements on the commit message? Just use your illusion :-) > For the Wiki change I'd need change permission (Username: wimmelg). I have just granted all permissions to your user. Regards. [1] https://gitbox.apache.org/repos/asf [2] http://syncope.apache.org/mailing-lists.html#IRC -- Francesco Chicchiriccò Tirasa - Open Source Excellence http://www.tirasa.net/ Member at The Apache Software Foundation Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail http://home.apache.org/~ilgrosso/