From notifications-return-50194-archive-asf-public=cust-asf.ponee.io@superset.apache.org Fri Sep 4 21:23:24 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 0B55C18037A for ; Fri, 4 Sep 2020 23:23:24 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 43276122013 for ; Fri, 4 Sep 2020 21:23:23 +0000 (UTC) Received: (qmail 40347 invoked by uid 500); 4 Sep 2020 21:23:23 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 40337 invoked by uid 99); 4 Sep 2020 21:23:23 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Sep 2020 21:23:23 +0000 From: =?utf-8?q?GitBox?= To: notifications@superset.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-superset=5D_eschutho_opened_a_new_pull_r?= =?utf-8?q?equest_=2310799=3A_use_svg_for_checkbox_component?= Message-ID: Date: Fri, 04 Sep 2020 21:23:22 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit eschutho opened a new pull request #10799: URL: https://github.com/apache/incubator-superset/pull/10799 ### SUMMARY Replaces the use of font-awesome for checkboxes with the svg components that already exist. There's also the potential to add the existing "half-checked" svg icon to the checkbox component as a prop as a future improvement. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF There are some minor visual differences with the new component: Before: ![Screen Recording 2020-09-04 at 12 12 06 PM](https://user-images.githubusercontent.com/5186919/92285586-8242d580-eeb9-11ea-9157-87566e07ddc0.gif) After: ![Screen Recording 2020-09-04 at 12 15 21 PM](https://user-images.githubusercontent.com/5186919/92285558-71925f80-eeb9-11ea-8011-79861ac975e6.gif) Note: there is no focus state for this new component, and the color is more green than blue. ### TEST PLAN A story and test were added, but it can be manually tested in the save dashboard modal as in the example. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [x ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org