From notifications-return-53098-archive-asf-public=cust-asf.ponee.io@superset.apache.org Tue Sep 29 04:15:05 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id D8D70180642 for ; Tue, 29 Sep 2020 06:15:05 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 1CE341218D8 for ; Tue, 29 Sep 2020 04:15:05 +0000 (UTC) Received: (qmail 22556 invoked by uid 500); 29 Sep 2020 04:15:04 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 22547 invoked by uid 99); 29 Sep 2020 04:15:04 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Sep 2020 04:15:04 +0000 From: =?utf-8?q?GitBox?= To: notifications@superset.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-superset=5D_betodealmeida_commented_on_p?= =?utf-8?q?ull_request_=2311098=3A_Add_UUID_column_to_ImportMixin?= Message-ID: <160135290448.32230.7545804678958353496.asfpy@gitbox.apache.org> Date: Tue, 29 Sep 2020 04:15:04 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: betodealmeida commented on pull request #11098: URL: https://github.com/apache/incubator-superset/pull/11098#issuecomment-700415440 > Overall looks simpler than I thought it would be. In the interest of minimizing the number of database migrations, do we want to alter `Dashboard.json_metadata` in the same migration? I'm not sure... on one hand, doing it in this PR would reduce the number of migrations, which is great. On the other hand, having PRs with DB migrations being as small as possible makes it easier to cherry pick them. Do you have any preferences? I think updating the column `Dashboard.position_json` to use UUIDs is simple, but I'm worried about updating the logic that touches it. We'd also have to update the examples. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org