From notifications-return-52235-archive-asf-public=cust-asf.ponee.io@superset.apache.org Wed Sep 23 04:23:23 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id B87A71806DD for ; Wed, 23 Sep 2020 06:23:22 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id E7196124141 for ; Wed, 23 Sep 2020 04:23:21 +0000 (UTC) Received: (qmail 40968 invoked by uid 500); 23 Sep 2020 04:23:20 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 40698 invoked by uid 99); 23 Sep 2020 04:23:19 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Sep 2020 04:23:19 +0000 From: =?utf-8?q?GitBox?= To: notifications@superset.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-superset=5D_codecov-commenter_edited_a_c?= =?utf-8?q?omment_on_pull_request_=2310916=3A_chore=3A_Moved_selectors_from_?= =?utf-8?q?class_to_data-test_specific_in_card=5Fview_tests?= Message-ID: <160083499913.32230.12934468598927365201.asfpy@gitbox.apache.org> Date: Wed, 23 Sep 2020 04:23:19 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: codecov-commenter edited a comment on pull request #10916: URL: https://github.com/apache/incubator-superset/pull/10916#issuecomment-694176161 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10916?src=pr&el=h1) Report > Merging [#10916](https://codecov.io/gh/apache/incubator-superset/pull/10916?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ccfd293227105ae1a5a24999a3b75e3db724273b?el=desc) will **decrease** coverage by `5.05%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10916/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10916?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #10916 +/- ## ========================================== - Coverage 65.81% 60.75% -5.06% ========================================== Files 815 383 -432 Lines 38327 24176 -14151 Branches 3600 0 -3600 ========================================== - Hits 25226 14689 -10537 + Misses 12997 9487 -3510 + Partials 104 0 -104 ``` | Flag | Coverage Δ | | |---|---|---| | #cypress | `?` | | | #javascript | `?` | | | #python | `60.75% <ø> (-0.71%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10916?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10916/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10916/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10916/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.85% <0.00%> (-11.44%)` | :arrow_down: | | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10916/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: | | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10916/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: | | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10916/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10916/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.56% <0.00%> (-0.83%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10916/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.70% <0.00%> (-0.06%)` | :arrow_down: | | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10916/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `67.26% <0.00%> (-0.03%)` | :arrow_down: | | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10916/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.47% <0.00%> (ø)` | | | ... and [432 more](https://codecov.io/gh/apache/incubator-superset/pull/10916/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10916?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10916?src=pr&el=footer). Last update [ccfd293...7e17571](https://codecov.io/gh/apache/incubator-superset/pull/10916?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org