From notifications-return-51464-archive-asf-public=cust-asf.ponee.io@superset.apache.org Thu Sep 17 03:13:11 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-he-de.apache.org (mxout1-he-de.apache.org [95.216.194.37]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id D312D1804BB for ; Thu, 17 Sep 2020 05:13:11 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-he-de.apache.org (ASF Mail Server at mxout1-he-de.apache.org) with SMTP id 34E1D62CBC for ; Thu, 17 Sep 2020 03:13:11 +0000 (UTC) Received: (qmail 44079 invoked by uid 500); 17 Sep 2020 03:13:10 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 44070 invoked by uid 99); 17 Sep 2020 03:13:10 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Sep 2020 03:13:10 +0000 From: =?utf-8?q?GitBox?= To: notifications@superset.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-superset=5D_graceguo-supercat_commented_?= =?utf-8?q?on_a_change_in_pull_request_=2310836=3A_feat=3A_Stop_pending_quer?= =?utf-8?q?ies_when_user_close_dashboard?= Message-ID: <160031239001.32230.16895435887867305640.asfpy@gitbox.apache.org> Date: Thu, 17 Sep 2020 03:13:10 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: graceguo-supercat commented on a change in pull request #10836: URL: https://github.com/apache/incubator-superset/pull/10836#discussion_r489920646 ########## File path: superset/db_engine_specs/base.py ########## @@ -1001,3 +1001,13 @@ def get_extra_params(database: "Database") -> Dict[str, Any]: logger.error(ex) raise ex return extra + + @classmethod + def stop_queries(cls, username: str, dashboard_id: int) -> None: Review comment: correct. Dashboard is in synchronized mode, there is no query id passed from query engine to dashboard. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org