From notifications-return-50415-archive-asf-public=cust-asf.ponee.io@superset.apache.org Wed Sep 9 17:51:56 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 68641180652 for ; Wed, 9 Sep 2020 19:51:56 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 97365121D29 for ; Wed, 9 Sep 2020 17:51:55 +0000 (UTC) Received: (qmail 63050 invoked by uid 500); 9 Sep 2020 17:51:55 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 63041 invoked by uid 99); 9 Sep 2020 17:51:55 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Sep 2020 17:51:55 +0000 From: =?utf-8?q?GitBox?= To: notifications@superset.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-superset=5D_codecov-commenter_edited_a_c?= =?utf-8?q?omment_on_pull_request_=2310723=3A_feat=28databases=29=3A_test_co?= =?utf-8?q?nnection_api?= Message-ID: <159967391522.32230.3953750555808892321.asfpy@gitbox.apache.org> Date: Wed, 09 Sep 2020 17:51:55 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: codecov-commenter edited a comment on pull request #10723: URL: https://github.com/apache/incubator-superset/pull/10723#issuecomment-683239330 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10723?src=pr&el=h1) Report > Merging [#10723](https://codecov.io/gh/apache/incubator-superset/pull/10723?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3b4a992861e9c6942b37a162316e2be9d48b380b?el=desc) will **increase** coverage by `0.06%`. > The diff coverage is `85.55%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10723/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10723?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #10723 +/- ## ========================================== + Coverage 65.40% 65.46% +0.06% ========================================== Files 802 803 +1 Lines 37872 37956 +84 Branches 3561 3561 ========================================== + Hits 24770 24849 +79 - Misses 12996 12998 +2 - Partials 106 109 +3 ``` | Flag | Coverage Δ | | |---|---|---| | #cypress | `55.57% <ø> (-0.53%)` | :arrow_down: | | #javascript | `61.65% <ø> (ø)` | | | #python | `61.18% <85.55%> (+0.27%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10723?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10723/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.15% <ø> (ø)` | | | [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/10723/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `75.74% <0.00%> (ø)` | | | [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/10723/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.25% <ø> (ø)` | | | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10723/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.48% <0.00%> (ø)` | | | [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10723/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `89.36% <70.96%> (-3.68%)` | :arrow_down: | | [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/incubator-superset/pull/10723/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `94.73% <94.73%> (ø)` | | | [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/10723/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (+0.96%)` | :arrow_up: | | [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/10723/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `100.00% <100.00%> (ø)` | | | [superset/databases/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/10723/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `99.34% <100.00%> (+0.03%)` | :arrow_up: | | [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/10723/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: | | ... and [15 more](https://codecov.io/gh/apache/incubator-superset/pull/10723/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10723?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10723?src=pr&el=footer). Last update [3b4a992...5d2e1f7](https://codecov.io/gh/apache/incubator-superset/pull/10723?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org