superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] eschutho opened a new pull request #10799: use svg for checkbox component
Date Fri, 04 Sep 2020 21:23:22 GMT

eschutho opened a new pull request #10799:
URL: https://github.com/apache/incubator-superset/pull/10799


   ### SUMMARY
   Replaces the use of font-awesome for checkboxes with the svg components that already exist.
There's also the potential to add the existing "half-checked" svg icon to the checkbox component
as a prop as a future improvement.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   There are some minor visual differences with the new component: 
   
   Before:
   ![Screen Recording 2020-09-04 at 12 12 06 PM](https://user-images.githubusercontent.com/5186919/92285586-8242d580-eeb9-11ea-9157-87566e07ddc0.gif)
   
   After:
   ![Screen Recording 2020-09-04 at 12 15 21 PM](https://user-images.githubusercontent.com/5186919/92285558-71925f80-eeb9-11ea-8011-79861ac975e6.gif)
   
   Note: there is no focus state for this new component, and the color is more green than
blue. 
   
   ### TEST PLAN
   A story and test were added, but it can be manually tested in the save dashboard modal
as in the example.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message