From notifications-return-40598-archive-asf-public=cust-asf.ponee.io@superset.apache.org Thu May 7 22:45:19 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0074D18062B for ; Fri, 8 May 2020 00:45:18 +0200 (CEST) Received: (qmail 72874 invoked by uid 500); 7 May 2020 22:45:18 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 72860 invoked by uid 99); 7 May 2020 22:45:18 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 May 2020 22:45:18 +0000 From: =?utf-8?q?GitBox?= To: notifications@superset.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-superset=5D_dpgaspar_commented_on_pull_r?= =?utf-8?q?equest_=239752=3A_fix=28mssql=29=3A_CAST_with_AT_produces_stateme?= =?utf-8?q?nts_with_syntax_errors?= Message-ID: <158889151834.26397.6918172028213293919.asfpy@gitbox.apache.org> Date: Thu, 07 May 2020 22:45:18 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: dpgaspar commented on pull request #9752: URL: https://github.com/apache/incubator-superset/pull/9752#issuecomment-625534249 Yes I know and totally agree @mistercrunch bad initial approach on my side. @bkyryliuk catching the error may be a good approach, could turn out to be difficult to pin the engine error, specific to non aliased functions, on the other hand, it's also a bit hard to parse the query and search for non aliased functions. So I may give it a try ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org