From notifications-return-40468-archive-asf-public=cust-asf.ponee.io@superset.apache.org Wed May 6 17:39:54 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3FD00180665 for ; Wed, 6 May 2020 19:39:54 +0200 (CEST) Received: (qmail 47687 invoked by uid 500); 6 May 2020 17:39:53 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 47647 invoked by uid 99); 6 May 2020 17:39:53 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 May 2020 17:39:53 +0000 From: =?utf-8?q?GitBox?= To: notifications@superset.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-superset=5D_dpgaspar_commented_on_pull_r?= =?utf-8?q?equest_=239752=3A_fix=28mssql=29=3A_CAST_with_AT_produces_stateme?= =?utf-8?q?nts_with_syntax_errors?= Message-ID: <158878679356.26397.17652928632864774427.asfpy@gitbox.apache.org> Date: Wed, 06 May 2020 17:39:53 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: dpgaspar commented on pull request #9752: URL: https://github.com/apache/incubator-superset/pull/9752#issuecomment-624790056 thks for the ideas @mistercrunch, we had/have a couple of problems with MSSQL on SQLLab. 1 - TOP wrapping was not working properly 2 - Even without TOP wrapping, functions on MSSQL like `COUNT`, `SUM` etc are set has ` and these are not supported by superset (pandas dataframes?) Given that, maybe 2 is a good approach, or a mix of 1 and 2. May be wrong here, but still think that altering SQL statements is dangerous/difficult and kind of out of scope for superset. Another option could be not forcing `TOP` on some engines but refusing to execute statements that don't have them? Note: This is scoped to MSSQL, because it was an obvious risky change ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org