From notifications-return-40455-archive-asf-public=cust-asf.ponee.io@superset.apache.org Wed May 6 15:26:26 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 600C718064F for ; Wed, 6 May 2020 17:26:26 +0200 (CEST) Received: (qmail 43425 invoked by uid 500); 6 May 2020 15:26:25 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 43415 invoked by uid 99); 6 May 2020 15:26:25 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 May 2020 15:26:25 +0000 From: =?utf-8?q?GitBox?= To: notifications@superset.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-superset=5D_villebro_commented_on_pull_r?= =?utf-8?q?equest_=239752=3A_fix=28mssql=29=3A_CAST_with_AT_produces_stateme?= =?utf-8?q?nts_with_syntax_errors?= Message-ID: <158877878575.26397.17434195744546911993.asfpy@gitbox.apache.org> Date: Wed, 06 May 2020 15:26:25 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: villebro commented on pull request #9752: URL: https://github.com/apache/incubator-superset/pull/9752#issuecomment-624716939 This is really a can of worms, and the deeper we go the more `sqlparse`-like logic we'll be introducing into Superset with unpleasant maintenance burden. I would almost propose deprecating advanced limiting for `TOP`-syntax dialects. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org