superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] rusackas commented on a change in pull request #9768: feat: partitionchart controls migration
Date Fri, 15 May 2020 16:41:43 GMT

rusackas commented on a change in pull request #9768:
URL: https://github.com/apache/incubator-superset/pull/9768#discussion_r425921966



##########
File path: superset-frontend/spec/javascripts/components/ColumnOption_spec.jsx
##########
@@ -19,9 +19,9 @@
 import React from 'react';
 import { shallow } from 'enzyme';
 
-import ColumnOption from 'src/components/ColumnOption';
-import ColumnTypeLabel from 'src/components/ColumnTypeLabel';
-import InfoTooltipWithTrigger from 'src/components/InfoTooltipWithTrigger';
+import { InfoTooltipWithTrigger } from '@superset-ui/control-utils';
+import ColumnOption from '../../../src/components/ColumnOption';
+import ColumnTypeLabel from '../../../src/components/ColumnTypeLabel';

Review comment:
       These two paths should use the absolute path, 'src/components/ColumnOption' and 'src/components/ColumnTypeLabel'
based on [this PR](https://github.com/apache/incubator-superset/pull/9761/). I thought the
linter might even catch it, but perhaps not. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message