From notifications-return-21542-archive-asf-public=cust-asf.ponee.io@superset.apache.org Mon May 27 00:45:14 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 461FD18062B for ; Mon, 27 May 2019 02:45:14 +0200 (CEST) Received: (qmail 51715 invoked by uid 500); 27 May 2019 00:45:13 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 51706 invoked by uid 99); 27 May 2019 00:45:13 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 May 2019 00:45:13 +0000 From: GitBox To: notifications@superset.apache.org Subject: [GitHub] [incubator-superset] MarcusSorealheis opened a new pull request #7597: Contributing Doc - fab edit refresh Message-ID: <155891791353.22672.778408708651351122.gitbox@gitbox.apache.org> Date: Mon, 27 May 2019 00:45:13 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit MarcusSorealheis opened a new pull request #7597: Contributing Doc - fab edit refresh URL: https://github.com/apache/incubator-superset/pull/7597 ### CATEGORY Choose one - [ ] Documentation ### SUMMARY Even though this is a legacy portion of the app that is likely to go away one day, the FAB-managed templates still play a vital role to the application and some of its core features. When I set to fix a bug in a FAB-managed template, I could not get the template to refresh. I learned through a bit of head-wall-butting and searching that removing `--with-threads` from the run command might solve the problem due to a race condition. I don't have enough information to say that's exactly what's going on for sure, but removing `--with-threads` did result in my template pages being updated. ### TEST PLAN 1. Make a change to a template file managed by FAB and check to see if the change is reflected, even after clearing your cache or browsing in incognito and start the app with: `FLASK_ENV=development superset run -p 8088 --with-threads --reload --debugger` 2. Stop the server and try to start it again with this command: FLASK_ENV=development superset run -p 8088 --reload --debugger ### ADDITIONAL INFORMATION - [ ] Has associated issue: "Fixes [#7493](https://github.com/apache/incubator-superset/issues/7493)" ### REVIEWERS ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org